Implement literal maps.

dart/frog/leg/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 75 matching lines @@
     return compiler.findHelper(const SourceString('indexSet'));
   }
 
   Element getEqualsNullInterceptor() {
     return compiler.findHelper(const SourceString('eqNull'));
   }
 
   Element getExceptionUnwrapper() {
     return compiler.findHelper(const SourceString('unwrapException'));
   }
+
+  Element getMapMaker() {
+    return compiler.findHelper(const SourceString('makeLiteralMap'));
+  }
 }
 
 class SsaBuilderTask extends CompilerTask {
   SsaBuilderTask(Compiler compiler)
     : super(compiler), interceptors = new Interceptors(compiler);
   String get name() => 'SSA builder';
   Interceptors interceptors;
 
   HGraph build(WorkItem work) {
     return measure(() {
@@ skipping 2123 matching lines @@
       // Mark both entry and exit with the information. You can
       // tell which one is which by comparing with blockInfo.start/end.
       // It doesn't matter which merge block we use, they won't be generating
       // any code, so put the end-marker on the last join block.
       entryBlock.labeledBlockInformation = blockInfo;
       current.labeledBlockInformation = blockInfo;
     }
   }
 
   visitLiteralMap(LiteralMap node) {
-    generateUnimplemented('literal map not implemented', isExpression: true);
+    List<HInstruction> inputs = <HInstruction>[];
+    for (Link<Node> link = node.entries.nodes;
+         !link.isEmpty();
+         link = link.tail) {
+      visit(link.head);
+      inputs.addLast(pop());
+      inputs.addLast(pop());
+    }
+    push(new HLiteralList(inputs, node.isConst()));
+    push(new HStatic(interceptors.getMapMaker()));

[ngeoffray, 2012/03/01 08:36:09]

Note that you don't really need to push, you could just call 'add'. Using 'add'
forces you to introduce a new local variable though.

No strong preference, I just wanted to make sure you knew you could call 'add'.

[ahe, 2012/03/06 15:34:12]

Done.

+    push(new HInvokeStatic(Selector.INVOCATION_1, <HInstruction>[pop(), pop()]));

[ngeoffray, 2012/03/01 08:36:09]

Line too long.

[ahe, 2012/03/06 15:34:12]

Done.

   }
 
   visitLiteralMapEntry(LiteralMapEntry node) {
-    compiler.unimplemented('SsaBuilder.visitLiteralMapEntry', node: node);
+    visit(node.value);
+    visit(node.key);
   }
 
   visitNamedArgument(NamedArgument node) {
     visit(node.expression);
   }
 
   visitSwitchStatement(SwitchStatement node) {
     generateUnimplemented('switch statement not implemented');
   }
 
@@ skipping 112 matching lines @@
     // Normally, we would call [close] here. However, then we hit
     // another unimplemented feature: aborting loop body. Simply
     // calling [add] does not work as it asserts that the instruction
     // isn't a control flow instruction. So we inline parts of [add].
     current.addAfter(current.last, new HThrow(message));
     if (isExpression) {
       stack.add(graph.addNewLiteralNull());
     }
   }
 }