Issue 9557010: Fix SimpleFileSystem to register a Blob when performing the CreateSnapshotFile function.

Issue 9557010: Fix SimpleFileSystem to register a Blob when performing the CreateSnapshotFile function. (Closed)

Created:
8 years, 9 months ago by michaeln

Modified:
8 years, 9 months ago

Reviewers:
kinuko, tony

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix SimpleFileSystem to register a Blob when performing the CreateSnapshotFile function. BUG=115603 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124454

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -5 lines)			Patch
M	webkit/tools/test_shell/simple_file_system.h	View		4 chunks	+11 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View	1	6 chunks	+52 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/simple_resource_loader_bridge.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm thanks! http://codereview.chromium.org/9557010/diff/1/webkit/tools/test_shell/simple_file_system.cc File webkit/tools/test_shell/simple_file_system.cc (right): http://codereview.chromium.org/9557010/diff/1/webkit/tools/test_shell/simple_file_system.cc#newcode306 webkit/tools/test_shell/simple_file_system.cc:306: DCHECK(g_io_thread) maybe?

8 years, 9 months ago (2012-03-01 02:31:54 UTC) #2

michaeln

http://codereview.chromium.org/9557010/diff/1/webkit/tools/test_shell/simple_file_system.cc File webkit/tools/test_shell/simple_file_system.cc (right): http://codereview.chromium.org/9557010/diff/1/webkit/tools/test_shell/simple_file_system.cc#newcode306 webkit/tools/test_shell/simple_file_system.cc:306: On 2012/03/01 02:31:54, kinuko wrote: > DCHECK(g_io_thread) maybe? Done.

8 years, 9 months ago (2012-03-01 02:38:07 UTC) #3

LGTM

Expand Messages | Collapse Messages