Issue 9555014: Revert 124288 (made mac browser and ui_tests flaky) - Add Media device notification to SystemMonito…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9555014: Revert 124288 (made mac browser and ui_tests flaky) - Add Media device notification to SystemMonito… (Closed)

Created:
8 years, 9 months ago by mattm

Modified:
8 years, 9 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 124288 (made mac browser and ui_tests flaky) - Add Media device notification to SystemMonitor and Mac impl BUG=110400 TEST=run chrome with -v=1, attach and a mass storage media device and observe the log entries for the attach and detach events. Review URL: https://chromiumcodereview.appspot.com/9363008 TBR=vandebo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124335

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -300 lines)			Patch
M	base/base.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/mac/foundation_util.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	base/mac/foundation_util.mm	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	base/system_monitor/system_monitor.h	View	7 chunks	+1 line, -26 lines	0 comments	Download
M	base/system_monitor/system_monitor.cc	View	3 chunks	+1 line, -26 lines	0 comments	Download
M	base/system_monitor/system_monitor_unittest.cc	View	3 chunks	+26 lines, -28 lines	0 comments	Download
D	base/test/mock_devices_changed_observer.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	base/test/mock_devices_changed_observer.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
D	content/browser/mac/media_device_notifications.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	content/browser/mac/media_device_notifications.mm	View	1 chunk	+0 lines, -133 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

8 years, 9 months ago (2012-03-01 02:24:55 UTC) #2

some have FATAL log messages like:
[2823:-1603066080:0229/163257:1503434947917:FATAL:media_device_notifications.mm(130)]
Check failed: err == noErr (-600 vs. 0)

ex:
http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%281%29/build...
http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%...
http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%283%29/build...


Also I noticed none of the mac_rel browser_test try runs on the CL completed
successfully.

Expand Messages | Collapse Messages