Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 9554011: Revert 125053 - Show applications page in aura compact mode. (Closed)

Created:
8 years, 9 months ago by dcheng
Modified:
8 years, 9 months ago
Reviewers:
flackr
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Revert 125053 - Show applications page in aura compact mode. BUG=116852 TEST=Launch chromeos aura in compact mode and observe that you can access applications on the new tab page. Review URL: http://codereview.chromium.org/9602029 TBR=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
8 years, 9 months ago (2012-03-06 01:19:15 UTC) #1
dcheng
8 years, 9 months ago (2012-03-06 01:23:58 UTC) #2
On 2012/03/06 01:19:15, dcheng wrote:

FYI, the failure stack:
[ RUN      ] WebUITest.WebUIToStandard
	base::debug::StackTrace::StackTrace() [0x276cb6e]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x27a5579]
	0x7ffc6bbffaf0
	NewTabUI::ShouldShowAppsPage() [0x1d05659]
	NewTabUI::NewTabUI() [0x1d07aaa]
	(anonymous namespace)::NewWebUI<>() [0x1cc0559]
	ChromeWebUIControllerFactory::CreateWebUIControllerForURL() [0x1cbf994]
	TabContents::CreateWebUI() [0x3a7721d]
	RenderViewHostManager::UpdateRendererStateForNavigate() [0x3b093cb]
	RenderViewHostManager::Navigate() [0x3b09853]
	TabContents::NavigateToEntry() [0x3a7f587]
	NavigationControllerImpl::NavigateToPendingEntry() [0x3a6f020]
	NavigationControllerImpl::LoadEntry() [0x3a73c7d]
	WebUITest::DoNavigationTest() [0x1231d4d]
	WebUITest_WebUIToStandard_Test::TestBody() [0x123300e]
	testing::Test::Run() [0x233c341]
	testing::TestInfo::Run() [0x233c40a]
	testing::TestCase::Run() [0x233c557]
	testing::internal::UnitTestImpl::RunAllTests() [0x233c7ed]
	testing::UnitTest::Run() [0x233aef3]
	base::TestSuite::Run() [0x3edf958]
	main [0x245a175]
	0x7ffc6bbeac4d
	0x423779

Powered by Google App Engine
This is Rietveld 408576698