Set incoming_only flag on the host side when NAT traversal is disabled.

Set incoming_only flag on the host side when NAT traversal is disabled.

BUG=115145
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124555

[Wez, 2012-03-01 19:36:35]

LGTM, and certainly good enough to land, but please see comments.

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
File remoting/protocol/transport_config.h (right):

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:17: enum NatTraversalMode {
nit: Is a single enum the best way to express this, versus separate "NAT
traversal" and "initiator" flags?

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:19: // connections. Note that connection
will always fail if both ends
nit: "outgoing" is a little confusing in a p2p context.  What we're saying is
that we will respond to incoming p2p channel connection attempts, but not
initiate any ourselves.

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:24: NAT_TRAVERSAL_PASSIVE,
nit: It's not really "passive" if you make an outgoing connection; perhaps
"client"/"disabled_client" or "outgoing"?

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:24: NAT_TRAVERSAL_PASSIVE,
We don't actually use PASSIVE right now, so perhaps it's best not to have it at
all?

[Sergey Ulanov, 2012-03-01 20:48:29]

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
File remoting/protocol/transport_config.h (right):

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:17: enum NatTraversalMode {
On 2012/03/01 19:36:35, Wez wrote:
> nit: Is a single enum the best way to express this, versus separate "NAT
> traversal" and "initiator" flags?

Yes, I considered two separate flags, but incoming_only flag doesn't make sense
with NAT traversal enabled. You can't use STUN/relay servers if you are not
allowed to connect to them.

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:19: // connections. Note that connection
will always fail if both ends
On 2012/03/01 19:36:35, Wez wrote:
> nit: "outgoing" is a little confusing in a p2p context.  What we're saying is
> that we will respond to incoming p2p channel connection attempts, but not
> initiate any ourselves.

Done.

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:24: NAT_TRAVERSAL_PASSIVE,
On 2012/03/01 19:36:35, Wez wrote:
> We don't actually use PASSIVE right now, so perhaps it's best not to have it
at
> all?

It's not used anywhere right now, but it might be useful in the future.

https://chromiumcodereview.appspot.com/9549029/diff/1/remoting/protocol/trans...
remoting/protocol/transport_config.h:24: NAT_TRAVERSAL_PASSIVE,
On 2012/03/01 19:36:35, Wez wrote:
> nit: It's not really "passive" if you make an outgoing connection; perhaps
> "client"/"disabled_client" or "outgoing"?

It is passive in terms of not actively trying to traverse NAT. Changed to
OUTGOING, though it seems confusing as well.

[commit-bot: I haz the power, 2012-03-01 20:49:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9549029/5001

[commit-bot: I haz the power, 2012-03-01 22:05:52]

Try job failure for 9549029-5001 (retry) on linux_rel for step
"remoting_unittests".
It's a second try, previously, step "remoting_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Sergey Ulanov, 2012-03-01 22:35:41]

Fixed unittests. Now they use the OUTGOING mode.

[commit-bot: I haz the power, 2012-03-01 22:49:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9549029/4003