Improve switch between gestures and touch mode when kEnableTouchEvents

Improve switch between gestures and touch mode when kEnableTouchEvents

Mostly works, the only problem is that the first touch or gesture on switching "modes" gets lost because Windows doesn't start a touch of the "other" type when TouchRegisterWindow is called while there's a touch in progress.

TBR=cpu

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124813

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124871

[scottmg, 2012-03-01 01:16:11]

Seem reasonable? (Most of the files are just plumbing the event type through,
only real changes in RWHV_win).

[scottmg, 2012-03-01 19:20:15]

+jam for OWNERS

[jam, 2012-03-02 00:15:14]

http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host.h (right):

http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host.h:755: void ProcessTouchAck(int
type, bool processed);
the ints in the code are confusing, why not pass WebKit::WebInputEvent::Type?

[scottmg, 2012-03-02 00:20:40]

On 2012/03/02 00:15:14, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> File content/browser/renderer_host/render_widget_host.h (right):
> 
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> content/browser/renderer_host/render_widget_host.h:755: void
ProcessTouchAck(int
> type, bool processed);
> the ints in the code are confusing, why not pass WebKit::WebInputEvent::Type?

Only because the other Acks use int already (ProcessKeyboardEventAck). Prefer it
changed?

[jam, 2012-03-02 00:37:55]

On 2012/03/02 00:20:40, scottmg wrote:
> On 2012/03/02 00:15:14, John Abd-El-Malek wrote:
> >
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> > File content/browser/renderer_host/render_widget_host.h (right):
> > 
> >
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> > content/browser/renderer_host/render_widget_host.h:755: void
> ProcessTouchAck(int
> > type, bool processed);
> > the ints in the code are confusing, why not pass
WebKit::WebInputEvent::Type?
> 
> Only because the other Acks use int already (ProcessKeyboardEventAck). Prefer
it
> changed?

oh, i wasn't aware it's that type. i think it should use the enum instead of int
if possible

[scottmg, 2012-03-02 01:15:45]

On 2012/03/02 00:37:55, John Abd-El-Malek wrote:
> On 2012/03/02 00:20:40, scottmg wrote:
> > On 2012/03/02 00:15:14, John Abd-El-Malek wrote:
> > >
> >
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> > > File content/browser/renderer_host/render_widget_host.h (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/9549020/diff/1/content/browser/renderer_host/r...
> > > content/browser/renderer_host/render_widget_host.h:755: void
> > ProcessTouchAck(int
> > > type, bool processed);
> > > the ints in the code are confusing, why not pass
> WebKit::WebInputEvent::Type?
> > 
> > Only because the other Acks use int already (ProcessKeyboardEventAck).
Prefer
> it
> > changed?
> 
> oh, i wasn't aware it's that type. i think it should use the enum instead of
int
> if possible

OK, changed to enum.

[jam, 2012-03-02 01:25:13]

lgtm from owners, i defer to cpu for the touch part

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.h (right):

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.h:110: OVERRIDE;
nit: convention is to not start a line with OVERRIDE, i.e. put the "bool ..." on
the next line

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_gtk.h (right):

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_gtk.h:114: OVERRIDE;
ditto

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_mac.h:282: OVERRIDE;
ditto

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_win.h (right):

http://codereview.chromium.org/9549020/diff/6001/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_win.h:201: OVERRIDE;
ditto

[cpu_(ooo_6.6-7.5), 2012-03-02 21:26:36]

http://codereview.chromium.org/9549020/diff/16001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/9549020/diff/16001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_win.cc:940: bool
touch_mode = !!RegisterTouchWindow(m_hWnd, TWF_WANTPALM);
we're not fans of the !! construct, you can use foo == TRUE

http://codereview.chromium.org/9549020/diff/16001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_win.cc:1944: TOUCHINPUT
fake_touch;
sounds like we send the fake a lot of times if we never switch to touch mode?

Come by to talk.

[scottmg, 2012-03-02 22:27:28]

https://chromiumcodereview.appspot.com/9549020/diff/16001/content/browser/ren...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://chromiumcodereview.appspot.com/9549020/diff/16001/content/browser/ren...
content/browser/renderer_host/render_widget_host_view_win.cc:940: bool
touch_mode = !!RegisterTouchWindow(m_hWnd, TWF_WANTPALM);
On 2012/03/02 21:26:36, cpu wrote:
> we're not fans of the !! construct, you can use foo == TRUE

Done.

https://chromiumcodereview.appspot.com/9549020/diff/16001/content/browser/ren...
content/browser/renderer_host/render_widget_host_view_win.cc:1944: TOUCHINPUT
fake_touch;
On 2012/03/02 21:26:36, cpu wrote:
> sounds like we send the fake a lot of times if we never switch to touch mode?

Good point, thanks. Changed to only send fake touch on GID_BEGIN.

[cpu_(ooo_6.6-7.5), 2012-03-02 23:23:41]

lgtm

[commit-bot: I haz the power, 2012-03-02 23:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9549020/18001

[commit-bot: I haz the power, 2012-03-03 01:36:10]

Change committed as 124813

[commit-bot: I haz the power, 2012-03-03 16:57:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9549020/21001

[commit-bot: I haz the power, 2012-03-03 17:21:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9549020/27002

[commit-bot: I haz the power, 2012-03-03 18:54:10]

Change committed as 124871