Add code to mint OAuth tokens from login-scoped OAuth token.

Add code to mint OAuth tokens from login-scoped OAuth token.
- Add a fetcher class, OAuth2TokenMintFetcher, to abstract OAuth2 token mint process.
- Add tests.

The work to use this in AppNotifyChannlesetup will be done in upcoming patch.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124486

[asargent_no_longer_on_chrome, 2012-03-01 00:53:36]

lgtm

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_consumer.h (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_consumer.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
nit: 2012  =)

(here and some of the other files you added)

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_fetcher.cc (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_fetcher.cc:39: static bool
GetStringFromDictionary(const DictionaryValue* dict,
nit: I think you can get rid of this function and just use
DictionaryValue::GetString() in the places where you were calling it

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_fetcher.h (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_fetcher.h:77: static GURL
MakeMintTokenUrl();
Given that this is called "MakeMintTokenUrl" and we generally speak about
"minting a token", would it make sense for this class to be named
"OAuth2MintTokenFetcher"? I guess "mint" can be either a verb (to do the
minting) or a noun (the place/thing that does generation).  No big deal either
way.

[Munjal (Google), 2012-03-01 18:38:52]

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_consumer.h (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_consumer.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/03/01 00:53:36, Antony Sargent wrote:
> nit: 2012  =)
> 
> (here and some of the other files you added)

Done.

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_fetcher.cc (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_fetcher.cc:39: static bool
GetStringFromDictionary(const DictionaryValue* dict,
On 2012/03/01 00:53:36, Antony Sargent wrote:
> nit: I think you can get rid of this function and just use
> DictionaryValue::GetString() in the places where you were calling it

Done.

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
File chrome/common/net/gaia/oauth2_token_mint_fetcher.h (right):

https://chromiumcodereview.appspot.com/9549013/diff/1/chrome/common/net/gaia/...
chrome/common/net/gaia/oauth2_token_mint_fetcher.h:77: static GURL
MakeMintTokenUrl();
On 2012/03/01 00:53:36, Antony Sargent wrote:
> Given that this is called "MakeMintTokenUrl" and we generally speak about
> "minting a token", would it make sense for this class to be named
> "OAuth2MintTokenFetcher"? I guess "mint" can be either a verb (to do the
> minting) or a noun (the place/thing that does generation).  No big deal either
> way. 

Done.

[jstritar, 2012-03-02 13:40:23]

LGTM

http://codereview.chromium.org/9549013/diff/1/chrome/common/net/gaia/oauth2_t...
File chrome/common/net/gaia/oauth2_token_mint_fetcher.h (right):

http://codereview.chromium.org/9549013/diff/1/chrome/common/net/gaia/oauth2_t...
chrome/common/net/gaia/oauth2_token_mint_fetcher.h:42: class
OAuth2TokenMintFetcher : public content::URLFetcherDelegate {
Could this be OAuth2TokenMint to use the noun form of mint?

http://codereview.chromium.org/9549013/diff/1/chrome/common/net/gaia/oauth2_t...
chrome/common/net/gaia/oauth2_token_mint_fetcher.h:77: static GURL
MakeMintTokenUrl();
On 2012/03/01 00:53:36, Antony Sargent wrote:
> Given that this is called "MakeMintTokenUrl" and we generally speak about
> "minting a token", would it make sense for this class to be named
> "OAuth2MintTokenFetcher"? I guess "mint" can be either a verb (to do the
> minting) or a noun (the place/thing that does generation).  No big deal either
> way. 

Yeah the names are a bit confusing. What do you think of saying 'Request'
instead of 'MintToken' here?

MakeRequestUrl
MakeRequestHeader
MakeRequestBody

Then the ParseMintTokenResponse method could be ParseResponse?