Move closure_blocks_leopard_compat to base now that it's used by two modules.

Move closure_blocks_leopard_compat to base now that it's used by two modules.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124331

[Mark Mentovai, 2012-03-01 01:25:11]

LG with one change.

http://codereview.chromium.org/9549012/diff/10001/base/base.gyp
File base/base.gyp (right):

http://codereview.chromium.org/9549012/diff/10001/base/base.gyp#newcode361
base/base.gyp:361: 'closure_blocks_leopard_compat',
I'd rather just make the targets that need it depend on
base.gyp:closure_blocks_leopard_compat. base doesn't need it, and you've already
set the dependency properly on the other targets that do need it.

[jam, 2012-03-01 01:27:19]

http://codereview.chromium.org/9549012/diff/10001/base/base.gyp
File base/base.gyp (right):

http://codereview.chromium.org/9549012/diff/10001/base/base.gyp#newcode361
base/base.gyp:361: 'closure_blocks_leopard_compat',
On 2012/03/01 01:25:11, Mark Mentovai wrote:
> I'd rather just make the targets that need it depend on
> base.gyp:closure_blocks_leopard_compat. base doesn't need it, and you've
already
> set the dependency properly on the other targets that do need it.

this is for base_unittests. won't that need it for the test?

[Mark Mentovai, 2012-03-01 01:29:39]

Yes, it does. LGTM, then. This is what I get for truing to review code from
my phone.
On Feb 29, 2012 8:27 PM, <jam@chromium.org> wrote:

>
>
http://codereview.chromium.**org/9549012/diff/10001/base/**base.gyp<http://co...
> File base/base.gyp (right):
>
> http://codereview.chromium.**org/9549012/diff/10001/base/**
>
base.gyp#newcode361<http://codereview.chromium.org/9549012/diff/10001/base/base.gyp#newcode361>
> base/base.gyp:361: 'closure_blocks_leopard_**compat',
> On 2012/03/01 01:25:11, Mark Mentovai wrote:
>
>> I'd rather just make the targets that need it depend on
>> base.gyp:closure_blocks_**leopard_compat. base doesn't need it, and
>>
> you've already
>
>> set the dependency properly on the other targets that do need it.
>>
>
> this is for base_unittests. won't that need it for the test?
>
>
http://codereview.chromium.**org/9549012/<http://codereview.chromium.org/9549...
>

[jam, 2012-03-01 01:31:49]

On 2012/03/01 01:29:39, Mark Mentovai wrote:
> Yes, it does. LGTM, then. This is what I get for truing to review code from
> my phone.

np, thanks for the quick review!

[Mark Mentovai, 2012-03-01 01:35:30]

$175 to whomever makes Rietveld not painful with Android Chrome.