Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 9549011: Revert 124283 - roll yasm 73761:124103 (Closed)

Created:
8 years, 9 months ago by mattm
Modified:
8 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 124283 - roll yasm 73761:124103 Only change: http://crrev.com/124103 yasm: Merge a clang warning fix. BUG=82628 TEST=none TBR=ajwong Review URL: http://codereview.chromium.org/9534001 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/README.chromium View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mattm
8 years, 9 months ago (2012-02-29 23:59:06 UTC) #1
mattm
8 years, 9 months ago (2012-03-01 00:00:14 UTC) #2
http://build.chromium.org/p/chromium/builders/Linux/builds/20783/steps/update...:

...
________ running '/usr/bin/python src/build/gyp_chromium' in
'/b/build/slave/Linux/build'
Updating projects from gyp files...
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 171, in <module>
    sys.exit(gyp.main(args))
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/__init__.py", line
471, in main
    options.circular_check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/__init__.py", line
111, in Load
    depth, generator_input_info, check, circular_check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 2292,
in Load
    depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 433,
in LoadTargetBuildFile
    includes, depth, check)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 387,
in LoadTargetBuildFile
    build_file_path)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 984,
in ProcessVariablesAndConditionsInDict
    ProcessConditionsInDict(the_dict, is_late, variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 861,
in ProcessConditionsInDict
    variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1010,
in ProcessVariablesAndConditionsInDict
    build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1025,
in ProcessVariablesAndConditionsInList
    ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1010,
in ProcessVariablesAndConditionsInDict
    build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1025,
in ProcessVariablesAndConditionsInList
    ProcessVariablesAndConditionsInDict(item, is_late, variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 984,
in ProcessVariablesAndConditionsInDict
    ProcessConditionsInDict(the_dict, is_late, variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 861,
in ProcessConditionsInDict
    variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1010,
in ProcessVariablesAndConditionsInDict
    build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 1029,
in ProcessVariablesAndConditionsInList
    expanded = ExpandVariables(item, is_late, variables, build_file)
  File "/b/build/slave/Linux/build/src/tools/gyp/pylib/gyp/input.py", line 709,
in ExpandVariables
    ' in ' + build_file
KeyError: 'Undefined variable yasm_output_filter in
src/third_party/libjpeg_turbo/libjpeg.gyp while loading dependencies of
src/third_party/iccjpeg/iccjpeg.gyp while loading dependencies of
src/third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp while loading
dependencies of src/third_party/WebKit/Source/WebKit/chromium/WebKit.gyp while
loading dependencies of src/content/browser/debugger/devtools_resources.gyp
while loading dependencies of src/chrome/chrome_resources.gyp while loading
dependencies of src/chrome/chrome.gyp while loading dependencies of
src/chrome/browser/sync/tools/sync_tools.gyp while loading dependencies of
src/build/all.gyp while trying to load src/build/all.gyp'
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit
status 1 in /b/build/slave/Linux/build

Powered by Google App Engine
This is Rietveld 408576698