Issue 9546051: Fix compile with debuggersupport=off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9546051: Fix compile with debuggersupport=off. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix compile with debuggersupport=off. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10952

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -33 lines)			Patch
M	Makefile	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/d8.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	test/mjsunit/regress/regress-1229.js	View	1 chunk	+0 lines, -18 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. http://codereview.chromium.org/9546051/diff/1/Makefile File Makefile (right): http://codereview.chromium.org/9546051/diff/1/Makefile#newcode76 Makefile:76: GYPFLAGS += -Dv8_can_use_vfp_instructions=true @Jakob: Is there any reason ...

8 years, 9 months ago (2012-03-07 10:47:41 UTC) #1

Michael Starzinger

8 years, 9 months ago (2012-03-07 10:52:19 UTC) #2

LGTM (with comments addressed).

https://chromiumcodereview.appspot.com/9546051/diff/1/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-1229.js (left):

https://chromiumcodereview.appspot.com/9546051/diff/1/test/mjsunit/regress/re...
test/mjsunit/regress/regress-1229.js:133: function bar1(x, y, z) {
Can you also get rid of the "1" suffix in "bar1" and "baz1"?

Expand Messages | Collapse Messages