Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/ui/panels/panel_overflow_browsertest.cc

Issue 9546001: Support detaching/attaching panels via inter-strip drags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch to land Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.cc ('k') | chrome/browser/ui/panels/panel_strip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_overflow_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_overflow_browsertest.cc b/chrome/browser/ui/panels/panel_overflow_browsertest.cc
index 14699bda02cede5e5785735886dbbc513685d19a..0ef6e136297f1498f4653b0172276c3c28e0ce85 100644
--- a/chrome/browser/ui/panels/panel_overflow_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_overflow_browsertest.cc
@@ -254,9 +254,13 @@ IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, UpdateDraggableStatus) {
PanelManager* panel_manager = PanelManager::GetInstance();
Panel* panel = CreatePanel("panel");
EXPECT_TRUE(panel->draggable());
- panel_manager->MovePanelToStrip(panel, PanelStrip::IN_OVERFLOW);
+ panel_manager->MovePanelToStrip(panel,
+ PanelStrip::IN_OVERFLOW,
+ PanelStrip::DEFAULT_POSITION);
EXPECT_FALSE(panel->draggable());
- panel_manager->MovePanelToStrip(panel, PanelStrip::DOCKED);
+ panel_manager->MovePanelToStrip(panel,
+ PanelStrip::DOCKED,
+ PanelStrip::DEFAULT_POSITION);
EXPECT_TRUE(panel->draggable());
panel->Close();
}
@@ -653,7 +657,7 @@ IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, CloseWithDelayedOverflow) {
// Hack. Put the "falsely closed" panel back into the panel strip
// so we can properly close it to wrap up this test.
- docked_strip->AddPanel(panel1);
+ docked_strip->AddPanel(panel1, PanelStrip::DEFAULT_POSITION);
panel0->Close();
panel1->Close();
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.cc ('k') | chrome/browser/ui/panels/panel_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698