Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/ui/panels/detached_panel_strip.h

Issue 9546001: Support detaching/attaching panels via inter-strip drags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/detached_panel_strip.h
diff --git a/chrome/browser/ui/panels/detached_panel_strip.h b/chrome/browser/ui/panels/detached_panel_strip.h
index 4ea0c4f64b19c568206802f4502588e7f36aaeeb..d5e883561cc12b4dc25357e16ba40f7708e17ed0 100644
--- a/chrome/browser/ui/panels/detached_panel_strip.h
+++ b/chrome/browser/ui/panels/detached_panel_strip.h
@@ -38,10 +38,17 @@ class DetachedPanelStrip : public PanelStrip {
virtual void MinimizePanel(Panel* panel) OVERRIDE;
virtual void RestorePanel(Panel* panel) OVERRIDE;
virtual bool CanShowPanelAsActive(const Panel* panel) const OVERRIDE;
+ virtual void SavePanelPlacement(Panel* panel) OVERRIDE;
+ virtual void LoadSavedPanelPlacement() OVERRIDE;
+ virtual void DiscardSavedPanelPlacement() OVERRIDE;
virtual bool CanDragPanel(const Panel* panel) const OVERRIDE;
- virtual void StartDraggingPanel(Panel* panel) OVERRIDE;
- virtual void DragPanel(Panel* panel, int delta_x, int delta_y) OVERRIDE;
- virtual void EndDraggingPanel(Panel* panel, bool cancelled) OVERRIDE;
+ virtual void StartDraggingPanelLocally(Panel* panel) OVERRIDE;
+ virtual void DragPanelLocally(Panel* panel,
+ int delta_x,
+ int delta_y) OVERRIDE;
+ virtual void EndDraggingPanelLocally(Panel* panel, bool cancelled) OVERRIDE;
+ virtual void AddDraggingPanel(Panel* panel,
+ const gfx::Point& position) OVERRIDE;
bool HasPanel(Panel* panel) const;
@@ -49,6 +56,13 @@ class DetachedPanelStrip : public PanelStrip {
const Panels& panels() const { return panels_; }
private:
+ struct PanelPlacement {
+ Panel* panel;
+ gfx::Point position;
+
+ PanelPlacement() : panel(NULL) { }
+ };
+
PanelManager* panel_manager_; // Weak, owns us.
// All panels in the panel strip must fit within this area.
@@ -57,6 +71,9 @@ class DetachedPanelStrip : public PanelStrip {
// Collection of all panels.
Panels panels_;
+ // Used to save the placement information for a panel.
+ PanelPlacement saved_panel_placement_;
+
DISALLOW_COPY_AND_ASSIGN(DetachedPanelStrip);
};

Powered by Google App Engine
This is Rietveld 408576698