Support detaching/attaching panels via inter-strip drags.

chrome/browser/ui/panels/panel_browser_window_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
 
 #include "base/logging.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 21 matching lines @@
 // screen coordinates (with (0,0) in the low-left corner).
 NSRect ConvertCoordinatesToCocoa(const gfx::Rect& bounds) {
   // Flip coordinates based on the primary screen.
   NSScreen* screen = [[NSScreen screens] objectAtIndex:0];
 
   return NSMakeRect(
       bounds.x(), NSHeight([screen frame]) - bounds.height() - bounds.y(),
       bounds.width(), bounds.height());
 }
 
+// Converts a point from the platfrom-independent screen coordinates (with the
+// (0,0) in the top-left corner of the primary screen) to the Cocoa screen
+// coordinates (with (0,0) in the low-left corner).
+NSPoint ConvertPointToCocoaCoordinates(const gfx::Point& point) {

[jennb, 2012/03/03 02:19:33]

Instead of defining this twice, please put somewhere and share it between these
2 files at least.

[jianli, 2012/03/07 19:14:31]

Done.

+  // Flip coordinates based on the primary screen.
+  NSScreen* screen = [[NSScreen screens] objectAtIndex:0];
+
+  return NSMakePoint(point.x(), NSHeight([screen frame]) - point.y());
+}
+
 }  // namespace
 
 // This creates a shim window class, which in turn creates a Cocoa window
 // controller which in turn creates actual NSWindow by loading a nib.
 // Overall chain of ownership is:
 // PanelWindowControllerCocoa -> PanelBrowserWindowCocoa -> Panel.
 NativePanel* Panel::CreateNativePanel(Browser* browser, Panel* panel,
                                       const gfx::Rect& bounds) {
   return new PanelBrowserWindowCocoa(browser, panel, bounds);
 }
@@ skipping 207 matching lines @@
 }
 
 void PanelBrowserWindowCocoa::EnsurePanelFullyVisible() {
   [controller_ ensureFullyVisible];
 }
 
 void PanelBrowserWindowCocoa::SetPanelAppIconVisibility(bool visible) {
   // TODO(dimich): to be implemented.
 }
 
+void PanelBrowserWindowCocoa::SetPanelAlwaysOnTop(bool on_top) {
+  [controller_ setAlwaysOnTop:on_top];
+}
+
 void PanelBrowserWindowCocoa::DidCloseNativeWindow() {
   DCHECK(!isClosed());
   panel_->OnNativePanelClosed();
   controller_ = NULL;
 }
 
 gfx::Size PanelBrowserWindowCocoa::WindowSizeFromContentSize(
     const gfx::Size& content_size) const {
   NSWindow* window = [controller_ window];
   NSRect content = NSMakeRect(0, 0,
@@ skipping 24 matching lines @@
                                             int index) {
   [controller_ tabDetached:contents->web_contents()];
 }
 
 // NativePanelTesting implementation.
 class NativePanelTestingCocoa : public NativePanelTesting {
  public:
   NativePanelTestingCocoa(NativePanel* native_panel);
   virtual ~NativePanelTestingCocoa() { }
   // Overridden from NativePanelTesting
-  virtual void PressLeftMouseButtonTitlebar(const gfx::Point& point) OVERRIDE;
+  virtual void PressLeftMouseButtonTitlebar(
+      const gfx::Point& mouse_location) OVERRIDE;
   virtual void ReleaseMouseButtonTitlebar() OVERRIDE;
-  virtual void DragTitlebar(int delta_x, int delta_y) OVERRIDE;
+  virtual void DragTitlebar(const gfx::Point& mouse_location) OVERRIDE;
   virtual void CancelDragTitlebar() OVERRIDE;
   virtual void FinishDragTitlebar() OVERRIDE;
   virtual bool VerifyDrawingAttention() const OVERRIDE;
   virtual bool VerifyActiveState(bool is_active) OVERRIDE;
   virtual bool IsWindowSizeKnown() const OVERRIDE;
   virtual bool IsAnimatingBounds() const OVERRIDE;
 
  private:
   PanelTitlebarViewCocoa* titlebar() const;
   // Weak, assumed always to outlive this test API object.
   PanelBrowserWindowCocoa* native_panel_window_;
 };
 
 // static
 NativePanelTesting* NativePanelTesting::Create(NativePanel* native_panel) {
   return new NativePanelTestingCocoa(native_panel);
 }
 
 NativePanelTestingCocoa::NativePanelTestingCocoa(NativePanel* native_panel)
   : native_panel_window_(static_cast<PanelBrowserWindowCocoa*>(native_panel)) {
 }
 
 PanelTitlebarViewCocoa* NativePanelTestingCocoa::titlebar() const {
   return [native_panel_window_->controller_ titlebarView];
 }
 
 void NativePanelTestingCocoa::PressLeftMouseButtonTitlebar(
-  const gfx::Point& point) {
-  [titlebar() pressLeftMouseButtonTitlebar];
+    const gfx::Point& mouse_location) {
+  [titlebar() pressLeftMouseButtonTitlebar:ConvertPointToCocoaCoordinates(
+      mouse_location)];
 }
 
 void NativePanelTestingCocoa::ReleaseMouseButtonTitlebar() {
   [titlebar() releaseLeftMouseButtonTitlebar];
 }
 
-void NativePanelTestingCocoa::DragTitlebar(int delta_x, int delta_y) {
-  [titlebar() dragTitlebarDeltaX:delta_x deltaY:delta_y];
+void NativePanelTestingCocoa::DragTitlebar(const gfx::Point& mouse_location) {
+  [titlebar() dragTitlebar:ConvertPointToCocoaCoordinates(mouse_location)];
 }
 
 void NativePanelTestingCocoa::CancelDragTitlebar() {
   [titlebar() cancelDragTitlebar];
 }
 
 void NativePanelTestingCocoa::FinishDragTitlebar() {
   [titlebar() finishDragTitlebar];
 }
 
 bool NativePanelTestingCocoa::VerifyDrawingAttention() const {
   return [titlebar() isDrawingAttention];
 }
 
 bool NativePanelTestingCocoa::VerifyActiveState(bool is_active) {
   // TODO(jianli): to be implemented.
   return false;
 }
 
 bool NativePanelTestingCocoa::IsWindowSizeKnown() const {
   return true;
 }
 
 bool NativePanelTestingCocoa::IsAnimatingBounds() const {
   return [native_panel_window_->controller_ isAnimatingBounds];
 }