This adds some GData private API to the file manager

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
@@ skipping 368 matching lines @@
   }
 
   mount_info->SetString("mountCondition",
       DiskMountManager::MountConditionToString(
           mount_point_info.mount_condition));
 
   return mount_info;
 }
 #endif  // defined(OS_CHROMEOS)
 
+// Builds a dictionary from the GDataFile file property information
+void BuildFilePropertyDictionary(const gdata::GDataFile& file,
+                                 base::DictionaryValue* property_dict) {
+  property_dict->SetString("thumbnailUrl", file.thumbnail_url().spec());
+
+  base::ListValue *pinned_list = new base::ListValue;
+  if (file.pinned_state() & gdata::GDataFile::PINNED_STATE_PINNED)
+    pinned_list->Append(new base::StringValue("pinned"));
+  if (file.pinned_state() & gdata::GDataFile::PINNED_STATE_PRESENT)
+    pinned_list->Append(new base::StringValue("present"));
+  property_dict->Set("pinnedState", pinned_list);
+
+  base::ListValue* authors_list = new base::ListValue;
+  const gdata::GDataFile::AuthorList& authors = file.authors();
+  for (gdata::GDataFile::AuthorList::const_iterator iter = authors.begin();
+       iter != authors.end(); ++iter) {
+    base::DictionaryValue* author_info = new base::DictionaryValue;
+    author_info->SetString("name", iter->first);
+    author_info->SetString("email", iter->second);
+    authors_list->Append(author_info);
+  }
+  property_dict->Set("authors", authors_list);

[zel, 2012/02/29 23:46:38]

remove authors

[Greg Spencer (Chromium), 2012/03/01 02:26:32]

Done.

+}
+
 }  // namespace
 
 class RequestLocalFileSystemFunction::LocalFileSystemCallbackDispatcher {
  public:
   static fileapi::FileSystemContext::OpenFileSystemCallback CreateCallback(
       RequestLocalFileSystemFunction* function,
       Profile* profile,
       int child_id,
       scoped_refptr<const Extension> extension) {
     return base::Bind(
@@ skipping 1398 matching lines @@
   ChromeURLDataManager::DataSource::SetFontAndTextDirection(dict);
 
   dict->SetString("PLAY_MEDIA",
       l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAY));
 
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableGData))
       dict->SetString("ENABLE_GDATA", "1");
 
   return true;
 }
+
+GetGDataFilePropertiesFunction::GetGDataFilePropertiesFunction() {
+}
+
+GetGDataFilePropertiesFunction::~GetGDataFilePropertiesFunction() {
+}
+
+bool GetGDataFilePropertiesFunction::RunImpl() {
+  if (args_->GetSize() != 1) {
+    return false;
+  }
+
+  ListValue* path_list = NULL;
+  args_->GetList(0, &path_list);
+  DCHECK(path_list);
+
+  std::string virtual_path;
+  size_t len = path_list->GetSize();
+  UrlList file_urls;
+  file_urls.reserve(len);
+  for (size_t i = 0; i < len; ++i) {
+    path_list->GetString(i, &virtual_path);
+    file_urls.push_back(GURL(virtual_path));
+  }
+
+  GetLocalPathsOnFileThreadAndRunCallbackOnUIThread(

[zel, 2012/02/29 23:46:38]

You don't need to move things to file thread for gdata entities.

Create utility function that would give you virtual_path back, something like:

    FilePath virtual_path;
    fileapi::FileSystemType type;
    GURL file_origin_url;
    if (!CrackFileSystemURL(file_url, &file_origin_url, &type,
                            &virtual_path)) {
      continue;
    }
    if (type != fileapi::kFileSystemTypeExternal) {
      NOTREACHED();
      continue;
    }


replace the same part in FileBrowserFunction::GetLocalPathsOnFileThread() with
that function.

[Greg Spencer (Chromium), 2012/03/01 02:26:32]

Done.

+      file_urls,
+      base::Bind(
+          &GetGDataFilePropertiesFunction::GetLocalPathsResponseOnUIThread,
+          this));
+  return true;
+}
+
+// If we don't find an entry for a file in the list, we insert an empty
+// attribute list
+// If we find an entry, but it's a dictionary instead of a file, then we
+// insert an empty attribute list.
+void GetGDataFilePropertiesFunction::GetLocalPathsResponseOnUIThread(
+    const FilePathList& files) {
+  base::ListValue* file_info = new base::ListValue;

[achuithb, 2012/02/29 23:33:06]

Could you please add a DCHECK for CurrentlyOn(BrowserThread::UI)?

[Greg Spencer (Chromium), 2012/03/01 02:26:32]

Actually, removed this because Zel says I don't need to do anything on the file
thread in between.  I added a check to make sure I was on the UI thread in
RunImpl though.

+  result_.reset(file_info);
+
+  gdata::GDataFileSystem* file_system =
+            gdata::GDataFileSystemFactory::GetForProfile(profile_);
+  DCHECK(file_system);
+
+  for (FilePathList::const_iterator iter = files.begin();
+      iter != files.end(); ++iter) {
+    scoped_refptr<gdata::ReadOnlyFindFileDelegate> find_delegate(

[zel, 2012/02/29 23:46:38]

yeah, you need a better one here, one that extracts what you need instead of
accessing unsafe find_delegate->file()

[Greg Spencer (Chromium), 2012/03/01 02:26:32]

Done.

+        new gdata::ReadOnlyFindFileDelegate());
+    file_system->FindFileByPath(*iter, find_delegate);
+    base::DictionaryValue* property_dict = new base::DictionaryValue;
+    file_info->Append(property_dict);
+
+    gdata::GDataFileBase* entry = find_delegate->file();
+    if (!entry) {
+      property_dict->SetString("error", "NOT_FOUND");
+      continue;  // Didn't find the file.
+    }
+    gdata::GDataFile* file = entry->AsGDataFile();
+    if (!file)
+      continue;  // Found a directory, just leave the empty attribute dict.
+    BuildFilePropertyDictionary(*file, property_dict);
+    file_info->Append(property_dict);
+  }
+  SendResponse(true);
+}