Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 9545005: Disable storing cookies from URLFetchers that run with a profile's cookie jar. (Closed)

Created:
8 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, GeorgeY, dhollowa+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, dyu1, tfarina, James Su, Ilya Sherman
Visibility:
Public.

Description

Disable storing cookies from URLFetchers that run with a profile's cookie jar. BUG=116253 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124282

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_download.cc View 2 chunks +2 lines, -0 lines 4 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jochen (gone - plz use gerrit)
plz review
8 years, 9 months ago (2012-02-29 22:39:34 UTC) #1
Ilya Sherman
http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode181 chrome/browser/autofill/autofill_download.cc:181: fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES); Do we want net::LOAD_DO_NOT_SEND_COOKIES as well?
8 years, 9 months ago (2012-02-29 22:45:27 UTC) #2
jochen (gone - plz use gerrit)
http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode181 chrome/browser/autofill/autofill_download.cc:181: fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES); On 2012/02/29 22:45:27, Ilya Sherman wrote: > Do ...
8 years, 9 months ago (2012-02-29 22:52:26 UTC) #3
Peter Kasting
AlternateNavURLFetcher, SearchProvider, and TemplateURLFetcher (the three in here I know) all LGTM. My only concern ...
8 years, 9 months ago (2012-02-29 22:57:05 UTC) #4
Ilya Sherman
http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode181 chrome/browser/autofill/autofill_download.cc:181: fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES); On 2012/02/29 22:52:26, jochen wrote: > On 2012/02/29 ...
8 years, 9 months ago (2012-02-29 22:58:28 UTC) #5
rpetterson
LGTM. Profiles should be fine. But I second Peter's comment about persisting this behavior.
8 years, 9 months ago (2012-02-29 23:00:57 UTC) #6
ian fette
On 2012/02/29 23:00:57, rpetterson wrote: > LGTM. Profiles should be fine. But I second Peter's ...
8 years, 9 months ago (2012-02-29 23:02:01 UTC) #7
GeorgeY
lgtm http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc File chrome/browser/autofill/autofill_download.cc (right): http://codereview.chromium.org/9545005/diff/1/chrome/browser/autofill/autofill_download.cc#newcode181 chrome/browser/autofill/autofill_download.cc:181: fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES); On 2012/02/29 22:58:28, Ilya Sherman wrote: > ...
8 years, 9 months ago (2012-02-29 23:09:52 UTC) #8
jochen (gone - plz use gerrit)
On 2012/02/29 23:02:01, ian fette wrote: > On 2012/02/29 23:00:57, rpetterson wrote: > > LGTM. ...
8 years, 9 months ago (2012-02-29 23:10:31 UTC) #9
willchan no longer on Chromium
Everything LGTM to me too as an interim fix for M17. The only question is ...
8 years, 9 months ago (2012-02-29 23:12:38 UTC) #10
Peter Kasting
On 2012/02/29 23:12:38, willchan wrote: > And in answer to the points others raised about ...
8 years, 9 months ago (2012-02-29 23:17:24 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-02-29 23:26:15 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698