Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: src/ic.cc

Issue 95433002: Remove strictmode from FindHandler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1171 1171
1172 1172
1173 Handle<Code> IC::ComputeHandler(LookupResult* lookup, 1173 Handle<Code> IC::ComputeHandler(LookupResult* lookup,
1174 Handle<Object> object, 1174 Handle<Object> object,
1175 Handle<String> name, 1175 Handle<String> name,
1176 Handle<Object> value) { 1176 Handle<Object> value) {
1177 InlineCacheHolderFlag cache_holder = GetCodeCacheForObject(*object); 1177 InlineCacheHolderFlag cache_holder = GetCodeCacheForObject(*object);
1178 Handle<HeapObject> stub_holder(GetCodeCacheHolder( 1178 Handle<HeapObject> stub_holder(GetCodeCacheHolder(
1179 isolate(), *object, cache_holder)); 1179 isolate(), *object, cache_holder));
1180 1180
1181 StrictModeFlag strict_mode = kNonStrictMode;
1182 if (kind() == Code::STORE_IC || kind() == Code::KEYED_STORE_IC) {
1183 strict_mode = StoreIC::GetStrictMode(extra_ic_state());
1184 }
1185 Handle<Code> code = isolate()->stub_cache()->FindHandler( 1181 Handle<Code> code = isolate()->stub_cache()->FindHandler(
1186 name, handle(stub_holder->map()), kind(), cache_holder, strict_mode); 1182 name, handle(stub_holder->map()), kind(), cache_holder);
1187 if (!code.is_null()) return code; 1183 if (!code.is_null()) return code;
1188 1184
1189 code = CompileHandler(lookup, object, name, value, cache_holder); 1185 code = CompileHandler(lookup, object, name, value, cache_holder);
1190 ASSERT(code->is_handler()); 1186 ASSERT(code->is_handler());
1191 1187
1192 if (code->type() != Code::NORMAL) { 1188 if (code->type() != Code::NORMAL) {
1193 HeapObject::UpdateMapCodeCache(stub_holder, name, code); 1189 HeapObject::UpdateMapCodeCache(stub_holder, name, code);
1194 } 1190 }
1195 1191
1196 return code; 1192 return code;
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
2772 #undef ADDR 2768 #undef ADDR
2773 }; 2769 };
2774 2770
2775 2771
2776 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2772 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2777 return IC_utilities[id]; 2773 return IC_utilities[id];
2778 } 2774 }
2779 2775
2780 2776
2781 } } // namespace v8::internal 2777 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698