WebUI TaskManager: Remember column settings

chrome/browser/resources/task_manager/preload.js

Index: chrome/browser/resources/task_manager/preload.js
diff --git a/chrome/browser/resources/task_manager/preload.js b/chrome/browser/resources/task_manager/preload.js
index d5e9952a28ade796597ad431d5fbba1170f1765e..e25503986c5432415c4dfc0bee4d28c543510a01 100644
--- a/chrome/browser/resources/task_manager/preload.js
+++ b/chrome/browser/resources/task_manager/preload.js
@@ -15,11 +15,53 @@ function taskChanged(start, length, tasks) {
   if (taskmanager) taskmanager.processTaskChange(task);
 }
 
+// Caches list of enabled columns to prevent frequent access to localStorage.

[James Hawkins, 2012/03/02 22:52:38]

Variables don't "do" things, so s/Caches/Cached/.

[yoshiki, 2012/03/05 03:10:56]

Done.

+var cachedEnabledColumns;
+
+/**
+ * Returns the dictionary which maps columnId with enablity of column.

[James Hawkins, 2012/03/02 22:52:38]

Same thing about enablity.

[yoshiki, 2012/03/05 03:10:56]

Done.

+ */
+function getEnabledColumns() {
+  // Use the cache after the second time since access to localStorage is slow.
+  if (cachedEnabledColumns)
+    return cachedEnabledColumns;
+
+  var json = window.localStorage.getItem(ENABLED_COLUMNS_KEY);
+  try {
+    cachedEnabledColumns = JSON.parse(json) || {};
+  } catch (e) {
+    cachedEnabledColumns = {};
+  }
+  for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
+    if (typeof(cachedEnabledColumns[DEFAULT_COLUMNS[i][0]]) == 'undefined')
+      cachedEnabledColumns[DEFAULT_COLUMNS[i][0]] = DEFAULT_COLUMNS[i][3];
+  }
+  return cachedEnabledColumns;
+}
+
+/**
+ * Returns whether the givin column is enabled or not.

[James Hawkins, 2012/03/02 22:52:38]

s/givin/given/

"Returns whether the given column (at |columnId|) is enabled or not."

[yoshiki, 2012/03/05 03:10:56]

Done.

+ */
+function isColumnEnabled(columnId) {
+  return (getEnabledColumns())[columnId];
+}
+
+/**
+ * Sets the given enablity of the given column.
+ */
+function setColumnEnablity(columnId, newChecked) {
+  commands.setUpdateColumn(columnId, newChecked);
+  cachedEnabledColumns[columnId] = newChecked;
+  var json = JSON.stringify(cachedEnabledColumns);
+  window.localStorage.setItem(ENABLED_COLUMNS_KEY, json);
+}
+
 // Enable the taskmanager model before the loading of scripts.
 (function () {
   for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
-    if (DEFAULT_COLUMNS[i][3])
-      commands.setUpdateColumn(DEFAULT_COLUMNS[i][0], true);
+    var columnId = DEFAULT_COLUMNS[i][0];
+    if (isColumnEnabled(columnId))
+      commands.setUpdateColumn(columnId, true);
   }
   commands.enableTaskManager();
   commands.setUpdateColumn('canInspect', true);