Support for multiple PeerConnections

content/renderer/media/media_stream_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_STREAM_IMPL_H_
 #define CONTENT_RENDERER_MEDIA_MEDIA_STREAM_IMPL_H_
 
 #include <list>
 #include <map>
 #include <string>
+#include <utility>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop_proxy.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/threading/thread.h"
 #include "content/common/content_export.h"
@@ skipping 44 matching lines @@
  public:
   MediaStreamImpl(
       MediaStreamDispatcher* media_stream_dispatcher,
       content::P2PSocketDispatcher* p2p_socket_dispatcher,
       VideoCaptureImplManager* vc_manager,
       MediaStreamDependencyFactory* dependency_factory);
   virtual ~MediaStreamImpl();
 
   virtual WebKit::WebPeerConnectionHandler* CreatePeerConnectionHandler(
       WebKit::WebPeerConnectionHandlerClient* client);
-  virtual void ClosePeerConnection();
+  virtual void ClosePeerConnection(PeerConnectionHandler* pc_handler);
   virtual webrtc::MediaStreamTrackInterface* GetLocalMediaStreamTrack(
       const std::string& label);
 
   // WebKit::WebUserMediaClient implementation
   virtual void requestUserMedia(
       const WebKit::WebUserMediaRequest& user_media_request,
       const WebKit::WebVector<WebKit::WebMediaStreamSource>&
           media_stream_source_vector) OVERRIDE;
   virtual void cancelUserMediaRequest(
       const WebKit::WebUserMediaRequest& user_media_request) OVERRIDE;
@@ skipping 21 matching lines @@
       const media_stream::StreamDeviceInfoArray& device_array) OVERRIDE;
   virtual void OnDevicesEnumerationFailed(int request_id) OVERRIDE;
   virtual void OnDeviceOpened(
       int request_id,
       const std::string& label,
       const media_stream::StreamDeviceInfo& device_info) OVERRIDE;
   virtual void OnDeviceOpenFailed(int request_id) OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(MediaStreamImplTest, Basic);
+  FRIEND_TEST_ALL_PREFIXES(MediaStreamImplTest, MultiplePeerConnections);
 
   class VideoRendererWrapper : public webrtc::VideoRendererWrapperInterface {
    public:
     VideoRendererWrapper();
     virtual cricket::VideoRenderer* renderer() OVERRIDE {
       return rtc_video_decoder_.get();
     }
     void SetVideoDecoder(RTCVideoDecoder* decoder);
 
    protected:
@@ skipping 19 matching lines @@
   // for the lifetime of RenderView.
   content::P2PSocketDispatcher* p2p_socket_dispatcher_;
 
   // We own network_manager_, must be deleted on the worker thread.
   content::IpcNetworkManager* network_manager_;
 
   scoped_ptr<content::IpcPacketSocketFactory> socket_factory_;
 
   scoped_refptr<VideoCaptureImplManager> vc_manager_;
 
-  // peer_connection_handler_ is a weak reference, owned by WebKit. It's valid
-  // until stop is called on it (which will call ClosePeerConnection on us).
-  // TODO(grunell): Support several PeerConnectionsHandlers.
-  PeerConnectionHandler* peer_connection_handler_;
+  // peer_connection_handlers_ contains raw references, owned by WebKit. A
+  // pointer is valid until stop is called on the object (which will call
+  // ClosePeerConnection on us and we remove the pointer).
+  std::list<PeerConnectionHandler*> peer_connection_handlers_;
 
   // We keep a list of the generated local tracks, so that we can add capture
   // devices when generated and also use them for recording.
   typedef talk_base::scoped_refptr<webrtc::MediaStreamTrackInterface>
       MediaStreamTrackPtr;
   typedef std::map<std::string, MediaStreamTrackPtr> MediaStreamTrackPtrMap;
   MediaStreamTrackPtrMap local_tracks_;
 
-  talk_base::scoped_refptr<VideoRendererWrapper> video_renderer_;
-  scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
+  // Native PeerConnection only supports 1:1 mapping between MediaStream and
+  // video tag/renderer, so we restrict to this too.
+  typedef talk_base::scoped_refptr<VideoRendererWrapper> VideoRendererPtr;
+  typedef std::pair<VideoRendererPtr, PeerConnectionHandler*> VideoRendererPair;
+  typedef std::map<std::string, VideoRendererPair> VideoRendererMap;

[tommi (sloooow) - chröme, 2012/02/29 13:37:00]

maybe a comment that documents what the key is?

[Henrik Grunell, 2012/03/23 12:51:56]

Done.

+  VideoRendererMap video_renderers_;
 
   // PeerConnection threads. signaling_thread_ is created from the
   // "current" chrome thread.
   talk_base::Thread* signaling_thread_;
   talk_base::Thread* worker_thread_;
   base::Thread chrome_worker_thread_;
 
   static int next_request_id_;
   typedef std::map<int, WebKit::WebUserMediaRequest> MediaRequestMap;
   MediaRequestMap user_media_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamImpl);
 };
 
 #endif  // CONTENT_RENDERER_MEDIA_MEDIA_STREAM_IMPL_H_