Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9539014: [uber page] Fix font for link-buttons. (Closed)

Created:
8 years, 9 months ago by csilv
Modified:
8 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[uber page] Fix font for link-buttons. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124472

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/shared/css/button.css View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
csilv
+dbeam for review
8 years, 9 months ago (2012-02-29 19:26:51 UTC) #1
Dan Beam
I would let estade review this as he's been messing with fonts and .link-button nodes ...
8 years, 9 months ago (2012-02-29 19:28:54 UTC) #2
csilv
+estade for review
8 years, 9 months ago (2012-02-29 19:46:29 UTC) #3
Evan Stade
https://chromiumcodereview.appspot.com/9539014/diff/1/chrome/browser/resources/shared/css/button.css File chrome/browser/resources/shared/css/button.css (right): https://chromiumcodereview.appspot.com/9539014/diff/1/chrome/browser/resources/shared/css/button.css#newcode84 chrome/browser/resources/shared/css/button.css:84: font-family: inherit; I believe it should be font: inherit. ...
8 years, 9 months ago (2012-02-29 22:42:50 UTC) #4
csilv
https://chromiumcodereview.appspot.com/9539014/diff/1/chrome/browser/resources/shared/css/button.css File chrome/browser/resources/shared/css/button.css (right): https://chromiumcodereview.appspot.com/9539014/diff/1/chrome/browser/resources/shared/css/button.css#newcode84 chrome/browser/resources/shared/css/button.css:84: font-family: inherit; On 2012/02/29 22:42:50, Evan Stade wrote: > ...
8 years, 9 months ago (2012-02-29 22:49:19 UTC) #5
Evan Stade
8 years, 9 months ago (2012-03-01 17:44:05 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698