Make socket permission also allow Pepper sockets

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 1406 matching lines @@
 }
 
 FilePath ChromeContentBrowserClient::GetDefaultDownloadDirectory() {
   return download_util::GetDefaultDownloadDirectory();
 }
 
 std::string ChromeContentBrowserClient::GetDefaultDownloadName() {
   return l10n_util::GetStringUTF8(IDS_DEFAULT_DOWNLOAD_FILENAME);
 }
 
-bool ChromeContentBrowserClient::AllowSocketAPI(const GURL& url) {
-  return url.is_valid() &&
-      allowed_socket_origins_.find(url.host()) != allowed_socket_origins_.end();
+bool ChromeContentBrowserClient::AllowSocketAPI(
+    content::BrowserContext* browser_context, const GURL& url) {
+  if (!url.is_valid())
+    return false;
+
+  std::string host = url.host();
+  if (allowed_socket_origins_.count(host))
+    return true;
+
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  if (!profile || !profile->GetExtensionService())
+    return false;
+
+  const Extension* extension = profile->GetExtensionService()->extensions()->
+      GetExtensionOrAppByURL(ExtensionURLInfo(url));
+  if (!extension)
+    return false;
+
+  if (extension->HasAPIPermission(ExtensionAPIPermission::kSocket))

[Mihai Parparita -not on Chrome, 2012/03/01 06:25:31]

I may need some more context about this CL, but I believe the plan for the
extension socket API is to require both the socket API permission, and the host
permission to connect to the specific host that the socket is open to.

[Dmitry Polukhin, 2012/03/01 06:36:05]

I'm sorry I'm not sure that I understand what do you mean by "host permission".
Perhaps it is the same as regex-capable whitelist for protocol/host but as far
as I can see it is not implemented yet.

+    return true;
+
+  return false;
 }
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 int ChromeContentBrowserClient::GetCrashSignalFD(
     const CommandLine& command_line) {
 #if defined(OS_ANDROID)
   // TODO(carlosvaldivia): Upstream breakpad code for Android and remove this
   // fork. http://crbug.com/113560
   NOTIMPLEMENTED();
 #else
@@ skipping 32 matching lines @@
 #if defined(USE_NSS)
 crypto::CryptoModuleBlockingPasswordDelegate*
     ChromeContentBrowserClient::GetCryptoPasswordDelegate(
         const GURL& url) {
   return browser::NewCryptoModuleBlockingDialogDelegate(
       browser::kCryptoModulePasswordKeygen, url.host());
 }
 #endif
 
 }  // namespace chrome