Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2841)

Unified Diff: dart/frog/leg/typechecker.dart

Issue 9539009: Generate code that throws an exception on unimplemented features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/ssa/closure.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/typechecker.dart
diff --git a/dart/frog/leg/typechecker.dart b/dart/frog/leg/typechecker.dart
index 661edc66f94856f245d2f0633ea93f73604ca6ed..b4ac9d9da585041d8aca27ec3fdf8c1d22f9db3a 100644
--- a/dart/frog/leg/typechecker.dart
+++ b/dart/frog/leg/typechecker.dart
@@ -633,7 +633,7 @@ class TypeCheckerVisitor implements Visitor<Type> {
}
visitContinueStatement(ContinueStatement node) {
- compiler.unimplemented('visitContinueStatement', node: node);
+ return StatementType.NOT_RETURNING;
}
visitForInStatement(ForInStatement node) {
@@ -647,11 +647,11 @@ class TypeCheckerVisitor implements Visitor<Type> {
}
visitLiteralMap(LiteralMap node) {
- compiler.unimplemented('visitLiteralMap', node: node);
+ fail(node);
}
visitLiteralMapEntry(LiteralMapEntry node) {
- compiler.unimplemented('visitLiteralMapEntry', node: node);
+ fail(node);
}
visitNamedArgument(NamedArgument node) {
@@ -659,7 +659,7 @@ class TypeCheckerVisitor implements Visitor<Type> {
}
visitSwitchStatement(SwitchStatement node) {
- compiler.unimplemented('visitSwitchStatement', node: node);
+ fail(node);
}
visitTryStatement(TryStatement node) {
@@ -667,14 +667,14 @@ class TypeCheckerVisitor implements Visitor<Type> {
}
visitScriptTag(ScriptTag node) {
- compiler.unimplemented('visitScriptTag', node: node);
+ fail(node);
}
visitCatchBlock(CatchBlock node) {
- compiler.unimplemented('visitCatchBlock', node: node);
+ fail(node);
}
visitTypedef(Typedef node) {
- compiler.unimplemented('visitTypedef', node: node);
+ fail(node);
}
}
« no previous file with comments | « dart/frog/leg/ssa/closure.dart ('k') | dart/tests/co19/co19-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698