client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart - Issue 9539003: Safely wrap window.top in frog dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart

Issue 9539003: Safely wrap window.top in frog dom. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and merge Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « client/dom/generated/src/wrapping/_FileEntryWrappingImplementation.dart ('k') | client/dom/generated/src/wrapping/_StorageInfoWrappingImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart

diff --git a/client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart b/client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart

index 11732ef0bf709154257dd7841572217633bc8785..ebf68f172a55ff5176fb5e0c07eeffb9f849f341 100644

--- a/client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart

+++ b/client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart

@@ -74,16 +74,10 @@ class _NavigatorWrappingImplementation extends DOMWrapperBase implements Navigat

static void _registerProtocolHandler(receiver, scheme, url, title) native;

void webkitGetUserMedia(String options, NavigatorUserMediaSuccessCallback successCallback, [NavigatorUserMediaErrorCallback errorCallback = null]) {

- if (errorCallback === null) {

- _webkitGetUserMedia(this, options, successCallback);

- return;

- } else {

- _webkitGetUserMedia_2(this, options, successCallback, errorCallback);

- return;

- }

+ _webkitGetUserMedia(this, options, successCallback, errorCallback);

+ return;

}

- static void _webkitGetUserMedia(receiver, options, successCallback) native;

- static void _webkitGetUserMedia_2(receiver, options, successCallback, errorCallback) native;

+ static void _webkitGetUserMedia(receiver, options, successCallback, errorCallback) native;

String get typeName() { return "Navigator"; }

}