Create Login UI for Demo User.

chrome/browser/chromeos/kiosk_mode/kiosk_mode_helper.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_KIOSK_MODE_KIOSK_MODE_HELPER_H_
+#define CHROME_BROWSER_CHROMEOS_KIOSK_MODE_KIOSK_MODE_HELPER_H_
+#pragma once
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/callback_forward.h"
+
+namespace base {
+template <typename T> struct DefaultLazyInstanceTraits;

[pastarmovj, 2012/03/05 15:22:25]

Do you really need this to be a singleton. Can it rather be instantiated
wherever it is needed. We have this policy of trying to reduce the number of
singleton objects in Chrome.

[rkc, 2012/03/05 23:16:13]

It _is instantiated when it's needed - isn't that what a lazy instance is all
about :)

About having more than one copy of it, since we establish trust only once during
a chrome session, this class is a natural singleton. We can try to force it to
another pattern but that would be, less than ideal.

+}
+
+// This class centralizes all our code to get KioskMode settings; since
+// KioskMode interferes with normal operations all over Chrome, having all
+// data about it pulled from a central location would make future
+// refactorings easier. This class also handles getting trust for the policies
+// via it's init method.
+//
+// Note: If Initialize is not called before the various Getters, we'll return
+// invalid values.
+//
+// TODO(rkc): Once the enterprise policy side of this code is checked in, add
+// code to pull from the enterprise policy instead of flags and constants.
+namespace chromeos {
+
+class KioskModeHelper {
+ public:
+  // This method checks if Kiosk Mode is enabled or not.
+  static bool IsKioskModeEnabled();
+
+  static KioskModeHelper* Get();
+
+  // Initialize the settings helper; this will wait till trust is established
+  // for the enterprise policies then call the callback to notify the caller.
+  void Initialize(const base::Closure& notify_initialized);
+  bool is_initialized() const { return is_initialized_; }
+
+  // Getters for various Kiosk Mode values.

[pastarmovj, 2012/03/05 15:22:25]

I'd rather comment what those are. Also please change the measurement unit for
the timeout policy to be ms because this is what is already established for all
other timing policies.

[rkc, 2012/03/16 00:17:33]

Changed to use base::TimeDelta instead.

+  std::string GetScreensaverPath() const;
+  int64 GetScreensaverTimeout() const;
+
+ private:
+  friend struct base::DefaultLazyInstanceTraits<KioskModeHelper>;
+  KioskModeHelper();
+
+  bool is_initialized_;
+
+  DISALLOW_COPY_AND_ASSIGN(KioskModeHelper);
+};
+
+

[pastarmovj, 2012/03/05 15:22:25]

Too many empty lines.

[rkc, 2012/03/16 00:17:33]

Done.

+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_KIOSK_MODE_KIOSK_MODE_HELPER_H_