Issue 9536018: Faster WriteUtf8 for medium size strings?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9536018: Faster WriteUtf8 for medium size strings?

Created:
8 years, 9 months ago by Erik Corry

Modified:
8 years, 9 months ago

Reviewers:
piscisaureus

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Faster WriteUtf8 for medium size strings?

Patch Set 2 : '' #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -1 line)			Patch
M	src/api.cc	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+60 lines, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piscisaureus

It seems to break String::Utf8Value so I was unable to test it.

8 years, 9 months ago (2012-02-29 18:04:46 UTC) #1

Erik Corry

On 2012/02/29 18:04:46, piscisaureus wrote: > It seems to break String::Utf8Value so I was unable ...

8 years, 9 months ago (2012-03-01 08:33:40 UTC) #2

piscisaureus

https://chromiumcodereview.appspot.com/9536018/diff/4001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/9536018/diff/4001/src/objects.cc#newcode6123 src/objects.cc:6123: buffer, start - boundary, end - boundary); `start - ...

8 years, 9 months ago (2012-03-01 14:21:18 UTC) #3

piscisaureus

8 years, 9 months ago (2012-03-01 14:54:28 UTC) #4

https://chromiumcodereview.appspot.com/9536018/diff/4001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/9536018/diff/4001/src/objects.cc#newco...
src/objects.cc:6123: buffer, start - boundary, end - boundary);
Never mind, this is correct.

https://chromiumcodereview.appspot.com/9536018/diff/4001/src/objects.cc#newco...
src/objects.cc:6127: buffer, start - boundary, end - boundary);
This should read:
`return first->RecursivelySerializeToUtf8(buffer, start, boundary);`

Expand Messages | Collapse Messages

Issue 9536018: Faster WriteUtf8 for medium size strings?

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages