runtime/vm/object.cc - Issue 9536016: Implement BigintOperations::ToDecimalCString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 9536016: Implement BigintOperations::ToDecimalCString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and deal better with overflows. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 0522d8cff93978f6149afcf0c661aa69263e1dd5..2b56c182637eedc80a394c6406213aac4274bc48 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -6555,9 +6555,7 @@ static uword ZoneAllocator(intptr_t size) {

const char* Bigint::ToCString() const {

- // TODO(florian): Add a BigintOperations::ToDecCString method and use that

- // here.

- return BigintOperations::ToHexCString(*this, &ZoneAllocator);

+ return BigintOperations::ToDecimalCString(*this, &ZoneAllocator);

}