Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: runtime/vm/bigint_operations_test.cc

Issue 9536016: Implement BigintOperations::ToDecimalCString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/bigint_operations_test.cc
diff --git a/runtime/vm/bigint_operations_test.cc b/runtime/vm/bigint_operations_test.cc
index 9c499dac147a44d690b74d16d5426cb58642a714..398339f9944157365f90b46c9a493e68df677712 100644
--- a/runtime/vm/bigint_operations_test.cc
+++ b/runtime/vm/bigint_operations_test.cc
@@ -391,21 +391,20 @@ TEST_CASE(BigintHexStrings) {
}
-#if 0
-// TODO(florian): Add a ToDecString method in bigint operations.
-// Turn this test back on once it is implemented.
TEST_CASE(BigintDecStrings) {
{
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString("0x123"));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("291", str);
}
{
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString("0xaBcEf"));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("703727", str);
}
@@ -413,7 +412,8 @@ TEST_CASE(BigintDecStrings) {
const char* in = "0x123456789";
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("4886718345", str);
}
@@ -421,7 +421,8 @@ TEST_CASE(BigintDecStrings) {
const char* in = "0xFFFFFFF";
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("268435455", str);
}
@@ -429,14 +430,16 @@ TEST_CASE(BigintDecStrings) {
const char* in = "0x10000000";
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("268435456", str);
}
{
const char* in = "0x123456789ABCDEF01234567890ABCDEF0123456789ABCDEF0";
const Bigint& bigint = Bigint::Handle(BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("7141946863373290020600059860922167424469804758405880798960",
str);
}
@@ -452,28 +455,32 @@ TEST_CASE(BigintDecStrings) {
{
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString("-0x123"));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("-291", str);
}
{
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString("-0xaBcEf"));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("-703727", str);
}
{
const char* in = "-0x123456789";
const Bigint& bigint = Bigint::Handle(BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("-4886718345", str);
}
{
const char* in = "-0x123456789ABCDEF01234567890ABCDEF0123456789ABCDEF0";
const Bigint& bigint = Bigint::Handle(BigintOperations::NewFromCString(in));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("-7141946863373290020600059860922167424469804758405880798960",
str);
}
@@ -489,11 +496,11 @@ TEST_CASE(BigintDecStrings) {
{
const Bigint& bigint = Bigint::Handle(
BigintOperations::NewFromCString("0x000000123"));
- const char* str = BigintOperations::ToDecCString(bigint, &ZoneAllocator);
+ const char* str =
+ BigintOperations::ToDecimalCString(bigint, &ZoneAllocator);
EXPECT_STREQ("291", str);
}
}
-#endif
static void TestBigintCompare(const char* a, const char* b, int compare) {

Powered by Google App Engine
This is Rietveld 408576698