Issue 9536011: Inline one level of recursive call of WriteToFlat for the common case of cons string list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9536011: Inline one level of recursive call of WriteToFlat for the common case of cons string list. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 7 months ago

Reviewers:
piscisaureus, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline one level of recursive call of WriteToFlat for the common case of cons string list. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10871

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	src/objects.cc	View		1 chunk	+14 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piscisaureus

https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc#newcode6869 src/objects.cc:6869: sink[boundary - from] = static_cast<sinkchar>(second->Get(0)); MSVC refuses to inline ...

8 years, 7 months ago (2012-05-08 00:00:09 UTC) #3

Yang

8 years, 7 months ago (2012-05-08 12:32:05 UTC) #4

On 2012/05/08 00:00:09, piscisaureus wrote:
> https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc
> File src/objects.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc#newcode6869
> src/objects.cc:6869: sink[boundary - from] =
> static_cast<sinkchar>(second->Get(0));
> MSVC refuses to inline the Get(0) call. My benchmarks show that the difference
> is significant though. Any chance we could get a __forceinline or
> __attribute__((always_inline)) decorator on the Get method?
> 
>
https://chromiumcodereview.appspot.com/9536011/diff/1/src/objects.cc#newcode6871
> src/objects.cc:6871: CopyChars(sink + boundary - from,
> Ditto.

Thanks for the comment. Follow-up CL: http://codereview.chromium.org/10332054/

Expand Messages | Collapse Messages