Do not show menus for opening datetime/network/language config pages on lock screen.

Do not show menus for opening datetime/network/language config pages on lock screen.

BUG=116216
TEST=manually checked the three buttons

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124598

[oshima, 2012-02-29 15:44:22]

drive-by:

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
File chrome/browser/ui/views/aura/status_area_host_aura.cc (right):

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
chrome/browser/ui/views/aura/status_area_host_aura.cc:153: return false;
this can also be
return command_id == StatusAreaButton::Delegate::SHOW_NETWORK_OPTIONS;

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
chrome/browser/ui/views/aura/status_area_host_aura.cc:157: return true;
how about just:

} else {
   return !chromeos::StatusAreaViewChromeos::IsScreenLockMode();
}

[Yusuke Sato, 2012-03-01 06:27:52]

Fixed. Please take another look.

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
File chrome/browser/ui/views/aura/status_area_host_aura.cc (right):

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
chrome/browser/ui/views/aura/status_area_host_aura.cc:153: return false;
On 2012/02/29 15:44:22, oshima wrote:
> this can also be
> return command_id == StatusAreaButton::Delegate::SHOW_NETWORK_OPTIONS;

Done.

http://codereview.chromium.org/9536007/diff/1/chrome/browser/ui/views/aura/st...
chrome/browser/ui/views/aura/status_area_host_aura.cc:157: return true;
On 2012/02/29 15:44:22, oshima wrote:
> how about just:
> 
> } else {
>    return !chromeos::StatusAreaViewChromeos::IsScreenLockMode();
> }

Done.

[oshima, 2012-03-01 19:25:41]

lgtm

[sky, 2012-03-01 20:52:51]

LGTM

[commit-bot: I haz the power, 2012-03-02 01:31:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9536007/4001

[commit-bot: I haz the power, 2012-03-02 04:51:11]

Try job failure for 9536007-4001 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...