test/cctest/test-api.cc - Issue 9536005: Rewrite test CHECK to work on all platforms, including MIPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 9536005: Rewrite test CHECK to work on all platforms, including MIPS (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index a7e45d18ef5a69c3e823c3705b6f4e9acaefb8f0..af37809cebf2c069b42b7791b0e034d74bba9925 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -12910,7 +12910,7 @@ static void ExternalArrayTestHelper(v8::ExternalArrayType array_type,

if (array_type == v8::kExternalDoubleArray ||

array_type == v8::kExternalFloatArray) {

CHECK_EQ(

- static_cast<int>(0x80000000),

+ static_cast<int>(i::OS::nan_value()),

static_cast<int>(jsobj->GetElement(7)->ToObjectChecked()->Number()));

} else {

CHECK_EQ(0, static_cast<int>(

« no previous file with comments | « no previous file | no next file » | no next file with comments »