Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9535013: Merge r10809 from the bleeding_edge to the 3.8 branch. (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merge r10809 from the bleeding_edge to the 3.8 branch. Ensure that executable pages are properly guarded. Split executable memory chunks into two pieces: header with all metadata (protection: RW) and body (protection: RWX). Separate header from metadata with a guard page and add a guard page after the page body. R=erik.corry@gmail.com BUG=http://crbug.com/115151 Review URL: https://chromiumcodereview.appspot.com/9452002 ------------------------------------------------------------------------ Committed: https://code.google.com/p/v8/source/detail?r=10878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -195 lines) Patch
M src/deoptimizer.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/heap.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap.cc View 22 chunks +30 lines, -28 lines 0 comments Download
M src/heap-inl.h View 4 chunks +3 lines, -8 lines 0 comments Download
M src/mark-compact.cc View 13 chunks +47 lines, -33 lines 0 comments Download
M src/objects-visiting.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-cygwin.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/serialize.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/serialize.cc View 3 chunks +13 lines, -3 lines 0 comments Download
M src/spaces.h View 23 chunks +68 lines, -51 lines 0 comments Download
M src/spaces.cc View 29 chunks +143 lines, -35 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/store-buffer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-02-29 16:43:35 UTC) #1
Vyacheslav Egorov (Chromium)
Redirecting to Michael.
8 years, 9 months ago (2012-02-29 16:44:18 UTC) #2
Michael Starzinger
8 years, 9 months ago (2012-02-29 16:54:14 UTC) #3 
LGTM (reviewed mark-compact.cc, because that's where the merge conflicts
happened, rubber-stamped the rest).

Powered by Google App Engine
This is Rietveld 408576698