Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/trusted/validator_arm/ncvalidate.cc

Issue 9535001: Add validation caching interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: More edits Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/ncvalidate.cc
diff --git a/src/trusted/validator_arm/ncvalidate.cc b/src/trusted/validator_arm/ncvalidate.cc
index 6243e52b555cdd076fe911fc5b7e59c4ba54c3a8..d61c2b26efe466fcdf9c5be116d3ccd0537f4e5b 100644
--- a/src/trusted/validator_arm/ncvalidate.cc
+++ b/src/trusted/validator_arm/ncvalidate.cc
@@ -72,10 +72,13 @@ NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) (
uint8_t *data,
size_t size,
int bundle_size,
- NaClCPUFeaturesArm *cpu_features) {
+ NaClCPUFeaturesArm *cpu_features,
+ struct NaClValidationCache *cache) {
NaClValidationStatus status = NaClValidationFailedNotImplemented;
UNREFERENCED_PARAMETER(cpu_features);
UNREFERENCED_PARAMETER(sb_kind);
+ /* The ARM validator is currently unsafe w.r.t. caching. */
+ UNREFERENCED_PARAMETER(cache);
if (bundle_size == 16) {
if (kind == NaClApplyCodeValidation) {
status = ((0 == NCValidateSegment(data, guest_addr, size))
« no previous file with comments | « src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c ('k') | src/trusted/validator_x86/ncenuminsts_x86_32.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698