Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: src/trusted/validator_arm/ncvalidate.cc

Issue 9535001: Add validation caching interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Bugfix Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 #include "native_client/src/trusted/validator_arm/ncvalidate.h" 7 #include "native_client/src/trusted/validator_arm/ncvalidate.h"
8 8
9 9
10 #include <vector> 10 #include <vector>
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 return 0; 65 return 0;
66 } 66 }
67 67
68 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) ( 68 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidator, arm, 32) (
69 enum NaClSBKind sb_kind, 69 enum NaClSBKind sb_kind,
70 NaClApplyValidationKind kind, 70 NaClApplyValidationKind kind,
71 uintptr_t guest_addr, 71 uintptr_t guest_addr,
72 uint8_t *data, 72 uint8_t *data,
73 size_t size, 73 size_t size,
74 int bundle_size, 74 int bundle_size,
75 NaClCPUFeaturesArm *cpu_features) { 75 NaClCPUFeaturesArm *cpu_features,
76 NaClValidationCache *cache,
77 void *cache_context) {
76 NaClValidationStatus status = NaClValidationFailedNotImplemented; 78 NaClValidationStatus status = NaClValidationFailedNotImplemented;
77 UNREFERENCED_PARAMETER(cpu_features); 79 UNREFERENCED_PARAMETER(cpu_features);
78 UNREFERENCED_PARAMETER(sb_kind); 80 UNREFERENCED_PARAMETER(sb_kind);
81 /* The ARM validator is currently unsafe w.r.t. caching. */
82 UNREFERENCED_PARAMETER(cache);
83 UNREFERENCED_PARAMETER(cache_context);
79 if (bundle_size == 16) { 84 if (bundle_size == 16) {
80 if (kind == NaClApplyCodeValidation) { 85 if (kind == NaClApplyCodeValidation) {
81 status = ((0 == NCValidateSegment(data, guest_addr, size)) 86 status = ((0 == NCValidateSegment(data, guest_addr, size))
82 ? NaClValidationSucceeded : NaClValidationFailed); 87 ? NaClValidationSucceeded : NaClValidationFailed);
83 } 88 }
84 } 89 }
85 return status; 90 return status;
86 } 91 }
87 92
88 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32) 93 NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32)
(...skipping 26 matching lines...) Expand all
115 UNREFERENCED_PARAMETER(guest_addr); 120 UNREFERENCED_PARAMETER(guest_addr);
116 UNREFERENCED_PARAMETER(data_old); 121 UNREFERENCED_PARAMETER(data_old);
117 UNREFERENCED_PARAMETER(data_new); 122 UNREFERENCED_PARAMETER(data_new);
118 UNREFERENCED_PARAMETER(size); 123 UNREFERENCED_PARAMETER(size);
119 UNREFERENCED_PARAMETER(bundle_size); 124 UNREFERENCED_PARAMETER(bundle_size);
120 UNREFERENCED_PARAMETER(cpu_features); 125 UNREFERENCED_PARAMETER(cpu_features);
121 return NaClValidationFailedNotImplemented; 126 return NaClValidationFailedNotImplemented;
122 } 127 }
123 128
124 EXTERN_C_END 129 EXTERN_C_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698