Webkit now disables CSS3 regions at runtime by default. This change allows regions to be turned bac…

Webkit now disables CSS3 regions at runtime by default. This change allows regions to be turned back on via a command line flag.

BUG=chromium:115937
TEST=pass the flag --enable-css-regions to chrome on start up

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124367

[matthewrobertson03, 2012-02-28 21:55:43]

I

[jamesr, 2012-02-28 22:27:48]

https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
File content/public/common/content_switches.h (right):

https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
content/public/common/content_switches.h:82: CONTENT_EXPORT extern const char
kEnableCssRegions[];
this shouldn't have CONTENT_EXPORT since the only use of this symbol is inside
the content/ directory

[matthewrobertson03, 2012-02-29 05:01:03]

On 2012/02/28 22:27:48, jamesr wrote:
>
https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
> File content/public/common/content_switches.h (right):
> 
>
https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
> content/public/common/content_switches.h:82: CONTENT_EXPORT extern const char
> kEnableCssRegions[];
> this shouldn't have CONTENT_EXPORT since the only use of this symbol is inside
> the content/ directory

removed CONTENT_EXPORT from content/public/common/content_switches.h:82

[matthewrobertson03, 2012-02-29 05:02:03]

On 2012/02/28 22:27:48, jamesr wrote:
>
https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
> File content/public/common/content_switches.h (right):
> 
>
https://chromiumcodereview.appspot.com/9523002/diff/1/content/public/common/c...
> content/public/common/content_switches.h:82: CONTENT_EXPORT extern const char
> kEnableCssRegions[];
> this shouldn't have CONTENT_EXPORT since the only use of this symbol is inside
> the content/ directory

removed CONTENT_EXPORT from content/public/common/content_switches.h:82

[jamesr, 2012-02-29 19:06:39]

LGTM.

I believe you'll need to get reviews for OWNERS in other directories, I do not
have OWNERS approval for everything in this patch (not sure I have OWNERS for
anything in this patch, for that matter).

[jamesr, 2012-02-29 21:19:05]

Darin, John - could you give OWNERS reviews for content/public, content/browser,
and webkit/ ?

[jam, 2012-02-29 22:28:24]

lgtm

[darin (slow to review), 2012-02-29 22:29:36]

LGTM

[commit-bot: I haz the power, 2012-02-29 22:38:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/matthewrobertson03@gmail.com/9523002/1...

[commit-bot: I haz the power, 2012-02-29 22:39:03]

Can't apply patch for file AUTHORS.
While running patch -p0 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 164.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[commit-bot: I haz the power, 2012-02-29 23:06:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/matthewrobertson03@gmail.com/9523002/1...

[commit-bot: I haz the power, 2012-03-01 05:30:17]

Change committed as 124367