Issue 9521014: Add base/android OWNERS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9521014: Add base/android OWNERS. (Closed)

Created:
8 years, 9 months ago by John Grabowski

Modified:
8 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org, bulach, Satish, joth

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base/android OWNERS. Needed for CLs like https://chromiumcodereview.appspot.com/9514018/. All OWNERs listed meet Chromium requirements (e.g. have been full Chromium committers for >6mo). BUG=None TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124083

Patch Set 1 #

Patch Set 2 : add Jay #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	A	base/android/OWNERS	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

8 years, 9 months ago (2012-02-29 01:19:29 UTC) #2

LGTM
On Feb 28, 2012 7:38 PM, <jrg@chromium.org> wrote:

> Reviewers: Mark Mentovai,
>
> Description:
> Add base/android OWNERS.
>
> Needed for CLs like
https://chromiumcodereview.**appspot.com/9514018/<https://chromiumcodereview....
> .
> All OWNERs listed meet Chromium requirements (e.g. have been full
> Chromium committers for >6mo).
>
> BUG=None
> TEST=
>
>
> Please review this at
http://chromiumcodereview.**appspot.com/9521014/<http://chromiumcodereview.ap...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  A base/android/OWNERS
>
>
> Index: base/android/OWNERS
> diff --git a/base/android/OWNERS b/base/android/OWNERS
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> 4b35bd60631e6012d063724ecf595b**9c3447b5ff
> --- /dev/null
> +++ b/base/android/OWNERS
> @@ -0,0 +1,4 @@
> +jrg@chromium.org
> +bulach@chromium.org
> +satish@chromium.org
> +joth@chromium.org
>
>
>

Expand Messages | Collapse Messages