Issue 9521010: Remove NOTIMPLEMENTED() from PlatformThread::SetThreadPriority() for posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9521010: Remove NOTIMPLEMENTED() from PlatformThread::SetThreadPriority() for posix. (Closed)

Created:
8 years, 9 months ago by scherkus (not reviewing)

Modified:
8 years, 9 months ago

Reviewers:
brettw, Timur Iskhodzhanov

CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove NOTIMPLEMENTED() from PlatformThread::SetThreadPriority() for posix. Change prevents log spam when using WebAudio, WebRTC, or HTML5 audio/video. The alternative of using #ifdefs at the callsites seems less ideal. Also remove related tsan suppression. BUG=100026, 116172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124222

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -30 lines)			Patch
M	base/threading/platform_thread_posix.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	base/threading/platform_thread_win.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/valgrind/tsan/suppressions.txt	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

we've gotten a few bug reports due to people seeing NOTIMPLEMENTED log spam when running ...

8 years, 9 months ago (2012-02-28 23:36:17 UTC) #1

LGTM indeed

Expand Messages | Collapse Messages