Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4637)

Unified Diff: chrome/browser/resources/net_internals/main.css

Issue 9521006: Cleanup some classnames to match style. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add a comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/main.css
diff --git a/chrome/browser/resources/net_internals/main.css b/chrome/browser/resources/net_internals/main.css
index 655e27baeca6da061f6a2973b5672bfe82f3deeb..2905cbfc8e9fe8694a3758b33791eefc99951832 100644
--- a/chrome/browser/resources/net_internals/main.css
+++ b/chrome/browser/resources/net_internals/main.css
@@ -1,8 +1,8 @@
/*
mmenke 2012/02/28 22:15:02 Should we be putting a second asterisk on these?
eroman 2012/02/28 22:28:32 We have some inconsistencies. I'll do another pass
-Copyright (c) 2011 The Chromium Authors. All rights reserved.
-Use of this source code is governed by a BSD-style license that can be
-found in the LICENSE file.
-*/
+ * Copyright (c) 2011 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
/* Only common styles should be declared here. */
@@ -26,38 +26,22 @@ body {
user-select: none;
}
-.logSourceEntry {
+.log-source-entry {
margin: 5px;
}
-.logSourceEntry * p {
+.log-source-entry * p {
font-weight: bold;
font-size: 12px;
}
-.logSourceEntry * td {
+.log-source-entry * td {
font-size: 10px;
}
-/* TODO(eroman): make this a classname instead */
-#events-view-details-log-box,
-#events-view-details-timeline-box,
-#http-cache-view-tab-content,
-#proxy-view-tab-content,
-#capture-view-tab-content,
-#import-view-tab-content,
-#export-view-tab-content,
-#dns-view-tab-content,
-#sockets-view-tab-content,
-#spdy-view-tab-content,
-#service-providers-view-tab-content,
-#test-view-tab-content,
-#hsts-view-tab-content,
-#http-throttling-view-tab-content,
-#logs-view-tab-content,
-#prerender-view-tab-content,
-#http-pipeline-view-tab-content,
-#chromeos-view-tab-content {
+/* This class should be given to top-level content boxes (like the view's main
+ * DIV). It gives them a consistent margin, and makes them scrollable. */
mmenke 2012/02/28 22:15:02 nit: Should make this consistent with the other c
eroman 2012/02/28 22:28:32 Done. However we use both styles in this file.
+.content-box {
mmenke 2012/02/28 22:15:02 Much better.
overflow: auto;
padding: 10px;
}
@@ -65,23 +49,23 @@ body {
/*
* Styles for TABLE that uses a thin collapsed border.
*/
-table.styledTable {
+table.styled-table {
border-collapse: collapse;
}
-table.styledTable,
-.styledTable th,
-.styledTable td {
+table.styled-table,
+.styled-table th,
+.styled-table td {
mmenke 2012/02/28 22:15:02 The unit tests use the name of this class to make
eroman 2012/02/28 22:28:32 Done.
border: 1px solid #777;
padding-right: 4px;
padding-left: 4px;
}
-.styledTable th {
+.styled-table th {
background: rgb(224,236,255);
}
-.styledTable th.title {
+.styled-table th.title {
background: rgb(255,217,217);
}
@@ -102,16 +86,8 @@ table.styledTable,
}
/**
- * Styling for an emphasized button.
- */
-.bigButton {
- font-size: 100%;
- font-weight: bold;
-}
-
-/**
* Styling for text indicating a potential problem or error state.
*/
-.warningText {
+.warning-text {
color: red;
}

Powered by Google App Engine
This is Rietveld 408576698