Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 9519001: Remove assertion on instance destruction. (Closed)

Created:
8 years, 9 months ago by brettw
Modified:
8 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Remove assertion on instance destruction. The way that we do the wrappers now with InstanceHandles means there's no danger of dangling pointers, and actually that you can't unregister yourself during instance shutdown since the PP_Instance->pp::Instance mapping has been torn down by the time the instance destructor is called. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ppapi/cpp/instance.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
lgtm
8 years, 9 months ago (2012-02-28 20:09:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9519001/1
8 years, 9 months ago (2012-02-28 21:21:15 UTC) #2
commit-bot: I haz the power
8 years, 9 months ago (2012-02-28 22:45:25 UTC) #3
Try job failure for 9519001-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698