Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/ui/panels/panel_manager.cc

Issue 9517010: Change panels to be able to turn off autoresize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback and fix issue with preferred size and auto resize having the same callback. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | content/browser/renderer_host/render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index b86f15e36d8092df68eebd978370104bab3640db..bbd9d7928a448c2759ec9d71370e842a9e04c938 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -174,20 +174,13 @@ void PanelManager::OnPanelExpansionStateChanged(Panel* panel) {
void PanelManager::OnPreferredWindowSizeChanged(
jennb 2012/03/01 00:14:40 Match name to new DueToAutoResize?
levin 2012/03/01 01:56:19 Done as discussed.
Panel* panel, const gfx::Size& preferred_window_size) {
- if (!auto_sizing_enabled_) {
- LOG(INFO) << "Resizing auto-resizable Panels is not supported yet.";
- return;
- }
+ DCHECK(auto_sizing_enabled_);
docked_strip_->ResizePanelWindow(panel, preferred_window_size);
}
void PanelManager::ResizePanel(Panel* panel, const gfx::Size& new_size) {
- // Explicit resizing is not allowed for auto-resizable panels for now.
- // http://crbug.com/109343
- if (panel->auto_resizable())
- return;
-
docked_strip_->ResizePanelWindow(panel, new_size);
+ panel->SetAutoResizable(false);
}
bool PanelManager::ShouldBringUpTitlebars(int mouse_x, int mouse_y) const {
« no previous file with comments | « chrome/browser/ui/panels/panel_manager.h ('k') | content/browser/renderer_host/render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698