Change panels to be able to turn off autoresize.

chrome/browser/ui/panels/panel_manager.cc

Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index b86f15e36d8092df68eebd978370104bab3640db..21a60c6889838be9167d57aad5c77648401138eb 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -174,20 +174,14 @@ void PanelManager::OnPanelExpansionStateChanged(Panel* panel) {
 
 void PanelManager::OnPreferredWindowSizeChanged(
     Panel* panel, const gfx::Size& preferred_window_size) {
-  if (!auto_sizing_enabled_) {
-    LOG(INFO) << "Resizing auto-resizable Panels is not supported yet.";
-    return;
-  }
-  docked_strip_->ResizePanelWindow(panel, preferred_window_size);
+  DCHECK(auto_sizing_enabled_);

[jennb, 2012/02/29 19:46:00]

Could one of these update-preferred-size IPCs been in flight while we change the
panel to not-auto-resizable? That would cause this dcheck to fail. The previous
if-check was a guard against this scenario.

[levin, 2012/02/29 23:48:28]

This is an important concern. It is handled here:
http://code.google.com/codesearch#OAMlx_jo-ck/src/content/browser/renderer_ho...

It would be unfortunate if every consumer of auto resize needed to be aware of
the ipc subtleties :).


However, one problem was that preferred size notifications were always enabled
on OSX so this callback was always done. I've fixed that by separating out the
callbacks for preferred size changes vs autoresize.

+  docked_strip_->ResizePanelWindow(panel, preferred_window_size,
+                                   PanelStrip::AUTORESIZE_ENABLED);
 }
 
 void PanelManager::ResizePanel(Panel* panel, const gfx::Size& new_size) {
-  // Explicit resizing is not allowed for auto-resizable panels for now.
-  // http://crbug.com/109343
-  if (panel->auto_resizable())
-    return;
-
-  docked_strip_->ResizePanelWindow(panel, new_size);
+  docked_strip_->ResizePanelWindow(panel, new_size,

[jennb, 2012/02/29 19:46:00]

Is it safe to separate this like this:

docked_strip_->ResizePanelWindow(panel, new_size);
panel->SetAutoResizable(false);

? That would make the ResizePanelWindow() method clearer and avoid the need
touch auto-resizable state of a panel for OnPreferredWindowSizeChanged().

[levin, 2012/02/29 23:48:28]

Good call. Done.

+                                   PanelStrip::AUTORESIZE_DISABLED);
 }
 
 bool PanelManager::ShouldBringUpTitlebars(int mouse_x, int mouse_y) const {