Change panels to be able to turn off autoresize.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
@@ skipping 834 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, ResizePanel) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   panel_manager->enable_auto_sizing(true);
 
   Panel* panel = CreatePanel("TestPanel");
   EXPECT_TRUE(panel->auto_resizable());
   EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
 
-  // Verify resizing an auto-resizable panel is a no-op for now.
-  // http://crbug.com/109343
+  // Verify resizing an auto-resizable panel works.
   gfx::Rect original_bounds = panel->GetBounds();
   gfx::Rect original_restored_bounds = panel->GetRestoredBounds();
-  gfx::Size new_size(150, 200);
-  panel_manager->ResizePanel(panel, new_size);
-  EXPECT_EQ(original_bounds, panel->GetBounds());
-  EXPECT_EQ(original_restored_bounds, panel->GetRestoredBounds());
-
-  // Verify resizing adjusts bounds correctly when not auto-resizable.
-  panel->SetAutoResizable(false);
+  // These should be identical because the panel is expanded.
+  EXPECT_EQ(original_bounds.size(), original_restored_bounds.size());
+  gfx::Size new_size(original_bounds.size());
+  new_size.Enlarge(5, 5);
   panel_manager->ResizePanel(panel, new_size);
   EXPECT_FALSE(panel->auto_resizable());
   EXPECT_EQ(new_size, panel->GetBounds().size());
   EXPECT_EQ(new_size, panel->GetRestoredBounds().size());
 
   // Verify current height unaffected when panel is not expanded.
   panel->SetExpansionState(Panel::MINIMIZED);
   int original_height = panel->GetBounds().height();
   new_size.Enlarge(5, 5);
   panel_manager->ResizePanel(panel, new_size);
   EXPECT_EQ(new_size.width(), panel->GetBounds().width());
   EXPECT_EQ(original_height, panel->GetBounds().height());
   EXPECT_EQ(new_size, panel->GetRestoredBounds().size());
 
+  // Make it autoresized again.
+  panel->SetAutoResizable();

[jennb, 2012/02/29 00:11:50]

takes a param

+  ui_test_utils::WindowedNotificationObserver enlarge(
+      chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED,
+      content::Source<Panel>(panel));
+  EXPECT_TRUE(ui_test_utils::ExecuteJavaScript(
+      panel_browser->GetSelectedWebContents()->GetRenderViewHost(),
+      std::wstring(),
+      L"changeSize(50);"));

[jennb, 2012/02/29 00:11:50]

This only applies to the update-preferred-size.html used in the
DISABLED_AutoResize test.

+  enlarge.Wait();
+
   panel->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, AnimateBounds) {
   Panel* panel = CreatePanelWithBounds("PanelTest", gfx::Rect(0, 0, 100, 100));
   scoped_ptr<NativePanelTesting> panel_testing(
       NativePanelTesting::Create(panel->native_panel()));
 
   // Set bounds with animation.
   gfx::Rect bounds = gfx::Rect(10, 20, 150, 160);
@@ skipping 1107 matching lines @@
   // position when tall panel brings up its titlebar.
   CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
   CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }