Update Bookmark widget icon design.

Update Bookmark widget icon design.

BUG=404834
Committed: https://crrev.com/58155312259959779c74cd7ea6f82b1f9bc41db2
Cr-Commit-Position: refs/heads/master@{#318092}

[aurimas (slooooooooow), 2015-02-24 23:27:29]

aurimas@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[aurimas (slooooooooow), 2015-02-24 23:27:29]

PTAL

[gone, 2015-02-24 23:45:11]

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java
(right):

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:215: int
iconFontSize = iconDensity * GENERATED_ICON_FONT_SIZE_DP / 160;
magic constants?  is there no better way to do this without manually computing
with the icon density?

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:220:
System.out.println("aurimas drawWidgetBackgroundToCanvas " + icon.getWidth());
nit: get rid of this.

[aurimas (slooooooooow), 2015-02-25 00:02:45]

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java
(right):

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:215: int
iconFontSize = iconDensity * GENERATED_ICON_FONT_SIZE_DP / 160;
On 2015/02/24 at 23:45:11, dfalcantara wrote:
> magic constants?  is there no better way to do this without manually computing
with the icon density?

Replaced this with DisplayMetrics.DENSITY_MEDIUM

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:215: int
iconFontSize = iconDensity * GENERATED_ICON_FONT_SIZE_DP / 160;
On 2015/02/24 at 23:45:11, dfalcantara wrote:
> magic constants?  is there no better way to do this without manually computing
with the icon density?

Replaced this with DisplayMetrics.DENSITY_MEDIUM

https://chromiumcodereview.appspot.com/951553003/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java:220:
System.out.println("aurimas drawWidgetBackgroundToCanvas " + icon.getWidth());
On 2015/02/24 at 23:45:11, dfalcantara wrote:
> nit: get rid of this.

Done

[gone, 2015-02-25 00:03:51]

lgtm

[aurimas (slooooooooow), 2015-02-25 00:05:59]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-02-25 00:06:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553003/40001

[commit-bot: I haz the power, 2015-02-25 01:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 01:04:09]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[aurimas (slooooooooow), 2015-02-25 01:34:47]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-02-25 01:34:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/951553003/#ps60001
(title: "Fix assets")

[commit-bot: I haz the power, 2015-02-25 01:35:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553003/60001

[aurimas (slooooooooow), 2015-02-25 02:19:40]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-02-25 02:19:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/951553003/#ps80001
(title: "Fix findbugs")

[commit-bot: I haz the power, 2015-02-25 02:21:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553003/80001

[commit-bot: I haz the power, 2015-02-25 03:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 03:02:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[aurimas (slooooooooow), 2015-02-25 03:15:44]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-02-25 03:15:45]

tedchoc: PTAL

[Ted C, 2015-02-25 17:19:31]

lgtm

[aurimas (slooooooooow), 2015-02-25 17:35:06]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-02-25 17:36:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553003/80001

[aurimas (slooooooooow), 2015-02-25 19:15:30]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-02-25 19:15:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/951553003/#ps100001
(title: "Add icon null check")

[commit-bot: I haz the power, 2015-02-25 19:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951553003/100001

[commit-bot: I haz the power, 2015-02-25 19:52:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-25 19:53:48]

Patchset 6 (id:??) landed as
https://crrev.com/58155312259959779c74cd7ea6f82b1f9bc41db2
Cr-Commit-Position: refs/heads/master@{#318092}