Add support for malformed types and postpone some related errors from compile

runtime/vm/class_finalizer.h

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CLASS_FINALIZER_H_
 #define VM_CLASS_FINALIZER_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 
 namespace dart {
@@ skipping 22 matching lines @@
   // Add 'interface' to 'interface_list' if it is not already in the list and
   // return true. Also return true if 'interface' is not added, because it is
   // not unique, i.e. it is already in the list.
   // Return false if 'interface' conflicts with an interface already in the list
   // with the same class, but different type arguments.
   // In the case of a conflict, set 'conflicting' to the existing interface.
   static bool AddInterfaceIfUnique(GrowableArray<AbstractType*>* interface_list,
                                    AbstractType* interface,
                                    AbstractType* conflicting);
 
+  enum TypeFinalization {

[srdjan, 2012/02/29 00:15:54]

Maybe FinalizationKind is a better name?

[regis, 2012/02/29 02:10:01]

Renamed to FinalizationMode.

+    kIgnore,  // Parsed type is ignored and replaced by Dynamic.
+    kDoNotResolve,  // Type resolution is postponed.
+    kTryResolve,  // Type resolution is attempted, but not required.
+    kFinalize,  // Type resolution and type finalization are required.
+                // A malformed type is tolerated.
+    kFinalizeWellFormed  // Error-free resolution and finalization are required.

[hausner, 2012/02/28 23:52:59]

There is at least one place in the parser where you depend on the order of the
enum values. Maybe you should add a comment. Also, it would be neat if the
comments lined up on the right.

[regis, 2012/02/29 00:05:23]

Done.

+                         // A malformed type is not tolerated.
+  };
+
   // Finalize given type while parsing class cls.
   // Also canonicalize type if applicable.
   static RawAbstractType* FinalizeType(const Class& cls,
-                                       const AbstractType& type);
+                                       const AbstractType& type,
+                                       TypeFinalization finalization);
+
+  // Replace the malformed type with Dynamic and, depending on the given type
+  // finalization mode and execution mode, mark the type as malformed or report
+  // a compile time error.
+  static void FinalizeMalformedType(const Class& cls,
+                                    const Type& type,
+                                    TypeFinalization finalization,
+                                    const char* format, ...);
 
   // Pending classes are classes that need to be finalized.
   static void AddPendingClasses(const GrowableArray<const Class*>& classes);
 
   // Return false if we still have classes pending to be finalized.
   static bool AllClassesFinalized();
 
   // Return whether class finalization failed.
   // The function returns true if the finalization was successful.
   // If finalization fails, an error message is set in the sticky error field
@@ skipping 14 matching lines @@
   static void FinalizeClass(const Class& cls, bool generating_snapshot);
   static bool IsSuperCycleFree(const Class& cls);
   static void CheckForLegalConstClass(const Class& cls);
   static RawClass* ResolveClass(const Class& cls,
                                 const UnresolvedClass& unresolved_class);
   static void ResolveSuperType(const Class& cls);
   static void ResolveDefaultClass(const Class& cls);
   static void ResolveInterfaces(const Class& cls,
                                 GrowableArray<const Class*>* visited);
   static void FinalizeTypeArguments(const Class& cls,
-                                    const AbstractTypeArguments& arguments);
-  static void ResolveType(const Class& cls, const AbstractType& type);
+                                    const AbstractTypeArguments& arguments,
+                                    TypeFinalization finalization);
+  static void ResolveType(const Class& cls,
+                          const AbstractType& type,
+                          TypeFinalization finalization);
   static void ResolveAndFinalizeUpperBounds(const Class& cls);
   static void ResolveAndFinalizeSignature(const Class& cls,
                                           const Function& function);
   static void ResolveAndFinalizeMemberTypes(const Class& cls);
   static void PrintClassInformation(const Class& cls);
   static void VerifyClassImplements(const Class& cls);
   static void CollectInterfaces(const Class& cls,
                                 GrowableArray<const Class*>* interfaces);
+  static void ReportError(const Error& error);
   static void ReportError(const Script& script,
                           intptr_t token_index,
                           const char* format, ...);
   static void ReportError(const char* format, ...);
-  static void ReportWarning(const Script& script,
-                            intptr_t token_index,
-                            const char* format, ...);
 };
 
 }  // namespace dart
 
 #endif  // VM_CLASS_FINALIZER_H_