Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 9514014: Restore -pie linker flag on Linux. (Closed)

Created:
8 years, 9 months ago by Chris Evans
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Restore -pie linker flag on Linux. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Evans
I think this is the simplest way to restore things. Note that this CL enables ...
8 years, 9 months ago (2012-02-28 21:58:44 UTC) #1
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-02-28 22:03:02 UTC) #2
Nico
This increases binary size by 5MB (!): http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=-1
8 years, 9 months ago (2012-02-29 02:47:45 UTC) #3
cevans
Yeah, sorry. We've previously decided to take this hit, though. This change is effectively just ...
8 years, 9 months ago (2012-02-29 02:50:29 UTC) #4
Nico
On Tue, Feb 28, 2012 at 6:50 PM, Chris Evans <cevans@google.com> wrote: > Yeah, sorry. ...
8 years, 9 months ago (2012-02-29 02:57:51 UTC) #5
cevans
8 years, 9 months ago (2012-02-29 03:02:31 UTC) #6
On Tue, Feb 28, 2012 at 6:57 PM, Nico Weber <thakis@chromium.org> wrote:

> On Tue, Feb 28, 2012 at 6:50 PM, Chris Evans <cevans@google.com> wrote:
> > Yeah, sorry. We've previously decided to take this hit, though. This
> change
> > is effectively just reverting a  recent security regression.
>
> Did you measure how much start up time a > 5% binary size increase costs?
>

I don't think we did (this was back in Jun 2011), the sordid history is
https://code.google.com/p/chromium/issues/detail?id=57908 on which I've
just cc:ed you. Note that we've been running with that hit, whatever is it,
on stable channel for multiple releases now. The thing I just fixed is
restoring back to our current stable behaviour -- the regression is a
recent thing on trunk.\

Powered by Google App Engine
This is Rietveld 408576698