Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: frog/corejs.dart

Issue 9513015: Fix XML tests on Safari and IE. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/client/html/XMLDocumentTests.dart ('k') | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/corejs.dart
diff --git a/frog/corejs.dart b/frog/corejs.dart
index 9df6b77b3939b993c9f658193a893c4593047e42..88b82977efe1b7d11ab90b631dd7b5b68b1d6023 100644
--- a/frog/corejs.dart
+++ b/frog/corejs.dart
@@ -389,30 +389,55 @@ function $dynamicSetMetadata(inputTable) {
/** Snippet for `$typeNameOf`. */
final String _TYPE_NAME_OF_FUNCTION = @"""
-$defProp(Object.prototype, '$typeNameOf', function() {
- var constructor = this.constructor;
- if (typeof(constructor) == 'function') {
- // The constructor isn't null or undefined at this point. Try
- // to grab hold of its name.
- var name = constructor.name;
- // If the name is a non-empty string, we use that as the type
- // name of this object. On Firefox, we often get 'Object' as
- // the constructor name even for more specialized objects so
- // we have to fall through to the toString() based implementation
- // below in that case.
- if (name && typeof(name) == 'string' && name != 'Object') return name;
+$defProp(Object.prototype, '$typeNameOf', (function() {
+ function constructorNameWithFallback(obj) {
+ var constructor = obj.constructor;
+ if (typeof(constructor) == 'function') {
+ // The constructor isn't null or undefined at this point. Try
+ // to grab hold of its name.
+ var name = constructor.name;
+ // If the name is a non-empty string, we use that as the type
+ // name of this object. On Firefox, we often get 'Object' as
+ // the constructor name even for more specialized objects so
+ // we have to fall through to the toString() based implementation
+ // below in that case.
+ if (typeof(name) == 'string' && name && name != 'Object') return name;
+ }
+ var string = Object.prototype.toString.call(obj);
+ return string.substring(8, string.length - 1);
}
- var string = Object.prototype.toString.call(this);
- var name = string.substring(8, string.length - 1);
- if (name == 'Window') {
- name = 'DOMWindow';
- } else if (name == 'Document') {
- name = 'HTMLDocument';
- } else if (name == 'XMLDocument') {
- name = 'Document';
+
+ function chrome$typeNameOf() {
+ return this.constructor.name;
}
- return name;
-});""";
+
+ function firefox$typeNameOf() {
+ var name = constructorNameWithFallback(this);
+ if (name == 'Window') return 'DOMWindow';
+ if (name == 'Document') return 'HTMLDocument';
+ if (name == 'XMLDocument') return 'Document';
+ return name;
+ }
+
+ function ie$typeNameOf() {
+ var name = constructorNameWithFallback(this);
+ if (name == 'Window') return 'DOMWindow';
+ // IE calls both HTML and XML documents 'Document', so we check for the
+ // xmlVersion property, which is the empty string on HTML documents.
+ if (name == 'Document' && this.xmlVersion) return 'Document';
+ if (name == 'Document') return 'HTMLDocument';
+ return name;
+ }
+
+ // If we're not in the browser, we're almost certainly running on v8.
+ if (typeof(navigator) != 'object') return chrome$typeNameOf;
+
+ var userAgent = navigator.userAgent;
+ if (/Chrome/.test(userAgent)) return chrome$typeNameOf;
+ if (/Firefox/.test(userAgent)) return firefox$typeNameOf;
+ if (/MSIE/.test(userAgent)) return ie$typeNameOf;
+ return function() { return constructorNameWithFallback(this); };
+})());""";
/** Snippet for `$inherits`. */
final String _INHERITS_FUNCTION = @"""
« no previous file with comments | « client/tests/client/html/XMLDocumentTests.dart ('k') | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698