content/shell/mac/exported_symbols.exp - Issue 9513006: First pass at content shell for the Mac. Doesn't work yet.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/mac/exported_symbols.exp

Issue 9513006: First pass at content shell for the Mac. Doesn't work yet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 __ZN17ShellMainDelegateC1Ev
	Mark Mentovai 2012/02/28 20:12:40 Can we come up with a better solution than forcing Can we come up with a better solution than forcing this and its destructor to be exposed? Perhaps the ContentMain wrapper (the “extern "C"” one I’m strongly recommending you adopt throughout this review) can take care of this, so that the application doesn’t need to know or care about it. Mark Mentovai 2012/02/28 20:12:40 Boilerplate lice and a description, as noted elsew Boilerplate lice and a description, as noted elsewhere in this review. Avi (use Gerrit) 2012/02/29 19:46:50 Everything in this file is mooted. Everything in this file is mooted.
	2 __ZN17ShellMainDelegateD1Ev

	3 __ZN7content11ContentMainEiPPKcPNS_19ContentMainDelegateE
	Mark Mentovai 2012/02/28 20:12:40 As mentioned previously, it’s unlikely that you ne As mentioned previously, it’s unlikely that you need to mention this name here, as whatever you need to export should be decorated with __attribute__((visibility("default"))).
OLD	NEW