content/shell/mac/Info.plist - Issue 9513006: First pass at content shell for the Mac. Doesn't work yet.

Side by Side Diff: content/shell/mac/Info.plist

Issue 9513006: First pass at content shell for the Mac. Doesn't work yet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>
	Mark Mentovai 2012/02/28 20:12:40 app-Info.plist. app-Info.plist. Avi (use Gerrit) 2012/02/29 19:46:50 Done. Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > app-Info.plist. Done.
	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

	3 <plist version="1.0">

	4 <dict>

	5 <key>CFBundleDevelopmentRegion</key>

	6 <string>English</string>
	Mark Mentovai 2012/02/28 20:12:40 English is deprecated. Use “en” here. English is deprecated. Use “en” here. Avi (use Gerrit) 2012/02/29 19:46:50 Done. Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > English is deprecated. Use “en” here. Done.
	7 <key>CFBundleExecutable</key>
	Mark Mentovai 2012/02/28 20:12:40 You should provide CFBundleDisplayName, which can You should provide CFBundleDisplayName, which can also be ${PRODUCT_NAME} like CFBundleName. Avi (use Gerrit) 2012/02/29 19:46:50 Done. Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > You should provide CFBundleDisplayName, which can also be ${PRODUCT_NAME} like > CFBundleName. Done.
	8 <string>${EXECUTABLE_NAME}</string>

	9 <key>CFBundleIconFile</key>

	10 <string>app.icns</string>

	11 <key>CFBundleIdentifier</key>

	12 <string>org.chromium.ContentShell</string>
	Mark Mentovai 2012/02/28 20:12:40 Ideally this would be switchable on the basis of w Ideally this would be switchable on the basis of whether the build is set to “official” or not. Avi (use Gerrit) 2012/02/29 19:46:50 I don't believe there is a plan to produce an offi Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > Ideally this would be switchable on the basis of whether the build is set to > “official” or not. I don't believe there is a plan to produce an official Chrome Content Shell.
	13 <key>CFBundleInfoDictionaryVersion</key>

	14 <string>6.0</string>

	15 <key>CFBundleName</key>

	16 <string>${PRODUCT_NAME}</string>

	17 <key>CFBundlePackageType</key>
	Mark Mentovai 2012/02/28 20:12:40 Remove CFBundlePackageType and CFBundleSignature. Remove CFBundlePackageType and CFBundleSignature. They’re only relevant in an .app if CFBundleSignature is meaningful, and in this case, it is not. Avi (use Gerrit) 2012/02/29 19:46:50 ... File "./gyp-mac-tool", line 138, in ExecCopy ... File "./gyp-mac-tool", line 138, in ExecCopyInfoPlist self._WritePkgInfo(dest) File "./gyp-mac-tool", line 147, in _WritePkgInfo MACTOOL copy-bundle-resource out/Debug/obj/gen/content/shell_resources.pak package_type = plist['CFBundlePackageType'] KeyError: 'CFBundlePackageType'
	18 <string>APPL</string>

	19 <key>CFBundleSignature</key>

	20 <string>????</string>

	21 <key>CFBundleVersion</key>

	22 <string>1.0</string>
	Mark Mentovai 2012/02/28 20:12:40 This is relevant to Launch Services, so we should This is relevant to Launch Services, so we should do better than using a hard-coded version number. 1.0 is fine for now, but there should be some sort of plan for versioning the content shell, and generating the CFBundleVersion will need to adhere to silly rules for how CFBundleVersions can be numbered.
	23 <key>NSMainNibFile</key>
	Mark Mentovai 2012/02/28 20:12:40 LSMinimumSystemVersion = 10.5.0. LSFileQuarantine LSMinimumSystemVersion = 10.5.0. LSFileQuarantineEnabled = true. Avi (use Gerrit) 2012/02/29 19:46:50 Done. Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > LSMinimumSystemVersion = 10.5.0. > > LSFileQuarantineEnabled = true. Done.
	24 <string>MainMenu</string>

	25 <key>NSPrincipalClass</key>

	26 <string>NSApplication</string>
	Mark Mentovai 2012/02/28 20:12:40 NSSupportsAutomaticGraphicsSwitching = true. (This NSSupportsAutomaticGraphicsSwitching = true. (This is for full Chrome equivalence.) Avi (use Gerrit) 2012/02/29 19:46:50 Done. Show quoted text On 2012/02/28 20:12:40, Mark Mentovai wrote: > NSSupportsAutomaticGraphicsSwitching = true. (This is for full Chrome > equivalence.) Done.
	27 </dict>

	28 </plist>

OLD	NEW

« content/shell/mac/English.lproj/MainMenu.xib ('K') | « content/shell/mac/English.lproj/MainMenu.xib ('k') | content/shell/mac/app.icns » ('j') | content/shell/mac/exported_symbols.exp » ('J')