chrome/app/unexported_symbols.exp - Issue 9513006: First pass at content shell for the Mac. Doesn't work yet.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/unexported_symbols.exp

Issue 9513006: First pass at content shell for the Mac. Doesn't work yet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 __ZN7content11ContentMainEiPPKcPNS_19ContentMainDelegateE
	Mark Mentovai 2012/02/28 20:12:40 1. what is “.exp”? Exported? This seems like the o 1. what is “.exp”? Exported? This seems like the opposite of that. 2. This controls exports for the framework, and we already have framework.order, so I’d suggest framework.unexport. 3. Mangled symbols are bad for exporting like this. Declare ContentMain as “extern "C"” and then the symbol name would be _ContentMain. It’s probably cleanest to provide an exported extern "C" ContentMain wrapper function that calls into the C++ content::ContentMain. 4. Provide a license boilerplate and maybe a description of why you’re doing this, as in framework.order. Avi (use Gerrit) 2012/02/29 19:46:50 Mooted. Mooted.
OLD	NEW