Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 9512005: [Sync] Move BridgedSyncNotifier and ChromeSyncNotificationBridge to glue/ (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)
Visibility:
Public.

Description

[Sync] Move BridgedSyncNotifier and ChromeSyncNotificationBridge to glue/ sync_notifier isn't supposed to have dependencies on chrome. BUG=113723 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124381

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix compile error #

Patch Set 3 : Fix DEPS #

Patch Set 4 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -688 lines) Patch
M chrome/browser/sync/glue/DEPS View 1 2 1 chunk +5 lines, -1 line 0 comments Download
A + chrome/browser/sync/glue/bridged_sync_notifier.h View 3 chunks +12 lines, -10 lines 0 comments Download
A + chrome/browser/sync/glue/bridged_sync_notifier.cc View 3 chunks +9 lines, -7 lines 0 comments Download
A + chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/sync/glue/chrome_sync_notification_bridge.h View 4 chunks +11 lines, -8 lines 0 comments Download
A + chrome/browser/sync/glue/chrome_sync_notification_bridge.cc View 4 chunks +11 lines, -8 lines 0 comments Download
A + chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 3 7 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/sync/notifier/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/sync/notifier/bridged_sync_notifier.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/sync/notifier/bridged_sync_notifier.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/sync/notifier/bridged_sync_notifier_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/sync/notifier/chrome_sync_notification_bridge.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/sync/notifier/chrome_sync_notification_bridge.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/sync/notifier/chrome_sync_notification_bridge_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc View 4 chunks +1 line, -56 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+zea for review https://chromiumcodereview.appspot.com/9512005/diff/1/chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc File chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc (left): https://chromiumcodereview.appspot.com/9512005/diff/1/chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc#oldcode102 chrome/browser/sync/notifier/sync_notifier_factory_unittest.cc:102: // BridgedSyncNotifier) and then trigger a ...
8 years, 9 months ago (2012-02-29 02:19:52 UTC) #1
Nicolas Zea
Is this is needed only because of the chrome_notification_types dependency? I still think I'd prefer ...
8 years, 9 months ago (2012-02-29 21:51:37 UTC) #2
akalin
On 2012/02/29 21:51:37, nzea wrote: > Is this is needed only because of the chrome_notification_types ...
8 years, 9 months ago (2012-03-01 00:56:08 UTC) #3
Nicolas Zea
By not public I mean something internal to sync. Basically, my instinct is to prefer ...
8 years, 9 months ago (2012-03-01 01:04:23 UTC) #4
akalin
Had to add a few more DEPS to glue/* tim, if you object to any ...
8 years, 9 months ago (2012-03-01 03:22:01 UTC) #5
akalin
8 years, 9 months ago (2012-03-01 07:44:35 UTC) #6
On 2012/03/01 03:22:01, akalin wrote:
> Had to add a few more DEPS to glue/*
> 
> tim, if you object to any of these, let me know, otherwise, I'll commit later
> tonight.

I don't know what's up with check_deps on the trybot -- it's referring to a file
that's deleted (moved) in this CL.

I'll just check in and keep an eye on the tree.

Powered by Google App Engine
This is Rietveld 408576698