Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 9511003: MIPS: Pass zone explicitly to zone-allocation on x64 and ARM. (Closed)

Created:
8 years, 9 months ago by kalmard
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Pass zone explicitly to zone-allocation on x64 and ARM. Port r10857 (87e52e7). Original commit message: This is a very mechanical change to reduce the number of calls to Isolate::Current that come with every plain new-allocation. BUG= TEST= Patch from Daniel Kalmar <kalmard@homejinni.com>;. Committed: https://code.google.com/p/v8/source/detail?r=10863

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -183 lines) Patch
M src/mips/lithium-mips.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 77 chunks +210 lines, -183 lines 3 comments Download

Messages

Total messages: 2 (0 generated)
kalmard
8 years, 9 months ago (2012-02-28 18:10:05 UTC) #1
fschneider
8 years, 9 months ago (2012-02-29 09:48:15 UTC) #2
LGTM.

I'll fix the indentation and land it.

http://codereview.chromium.org/9511003/diff/1/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):

http://codereview.chromium.org/9511003/diff/1/src/mips/lithium-mips.cc#newcod...
src/mips/lithium-mips.cc:586: Register::ToAllocationIndex(reg));
Indentation.

http://codereview.chromium.org/9511003/diff/1/src/mips/lithium-mips.cc#newcod...
src/mips/lithium-mips.cc:592: DoubleRegister::ToAllocationIndex(reg));
Indentation.

http://codereview.chromium.org/9511003/diff/1/src/mips/lithium-mips.cc#newcod...
src/mips/lithium-mips.cc:614: LUnallocated::USED_AT_START));
Indentation.

Powered by Google App Engine
This is Rietveld 408576698