Issue 9511002: MIPS: Implement inlining of constructor calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9511002: MIPS: Implement inlining of constructor calls. (Closed)

Created:
8 years, 9 months ago by kalmard

Modified:
8 years, 9 months ago

Reviewers:
kisg, Paul Lind, danno, Michael Starzinger

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Implement inlining of constructor calls. Port r10849 (b0fe79c). Also included: Fixed a bug in GenerateRecordCallTarget. This bug prevented certain functions from being registered as Monomorphic and thus prevented them from being inlined using the new system (b0fe79c). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10862

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -23 lines)			Patch
M	src/mips/builtins-mips.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+7 lines, -3 lines	1 comment	Download
M	src/mips/deoptimizer-mips.cc	View	8 chunks	+115 lines, -11 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+13 lines, -5 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 9 months ago (2012-02-29 09:48:21 UTC) #2

LGTM. Landed.

https://chromiumcodereview.appspot.com/9511002/diff/1/src/mips/code-stubs-mip...
File src/mips/code-stubs-mips.cc (right):

https://chromiumcodereview.appspot.com/9511002/diff/1/src/mips/code-stubs-mip...
src/mips/code-stubs-mips.cc:5377: __ Branch(&done);
Removed this obsolete branch before landing.

Expand Messages | Collapse Messages